]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: pca9570: Use devm_mutex_init() for mutex initialization
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 13 Jan 2026 11:10:52 +0000 (12:10 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Tue, 13 Jan 2026 14:17:35 +0000 (15:17 +0100)
Use devm_mutex_init() since it brings some benefits when
CONFIG_DEBUG_MUTEXES is enabled.

Reviewed-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20260113111156.188051-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
drivers/gpio/gpio-pca9570.c

index c5a1287079a0633cb5f947ff813a9cce8a9041b2..eae35135c71ed2eff4e7d054f85abbbba53d7ad6 100644 (file)
@@ -115,7 +115,9 @@ out:
 
 static int pca9570_probe(struct i2c_client *client)
 {
+       struct device *dev = &client->dev;
        struct pca9570 *gpio;
+       int ret;
 
        gpio = devm_kzalloc(&client->dev, sizeof(*gpio), GFP_KERNEL);
        if (!gpio)
@@ -132,7 +134,9 @@ static int pca9570_probe(struct i2c_client *client)
        gpio->chip.ngpio = gpio->chip_data->ngpio;
        gpio->chip.can_sleep = true;
 
-       mutex_init(&gpio->lock);
+       ret = devm_mutex_init(dev, &gpio->lock);
+       if (ret)
+               return ret;
 
        /* Read the current output level */
        pca9570_read(gpio, &gpio->out);