staging: erofs: fix memleak of inode's shared xattr array

commit 3b1b5291f79d040d549d7c746669fc30e8045b9b upstream.

If it fails to read a shared xattr page, the inode's shared xattr array
is not freed. The next time the inode's xattr is accessed, the previously
allocated array is leaked.

Signed-off-by: Sheng Yong <shengyong1@huawei.com>
Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
Cc: <stable@vger.kernel.org> # 4.19+
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
index e30de2476fd038fa1e343970cf18ff36b443a015..04eb75bbe9a315b29082da6a0f238239a63fd1fd 100644 (file)
--- a/drivers/staging/erofs/xattr.c
+++ b/drivers/staging/erofs/xattr.c
@@ -111,8 +111,11 @@ static int init_inode_xattrs(struct inode *inode)
 
                        it.page = erofs_get_meta_page(sb,
                                ++it.blkaddr, S_ISDIR(inode->i_mode));
-                       if (IS_ERR(it.page))
+                       if (IS_ERR(it.page)) {
+                               kfree(vi->xattr_shared_xattrs);
+                               vi->xattr_shared_xattrs = NULL;
                                return PTR_ERR(it.page);
+                       }
 
                        it.kaddr = kmap_atomic(it.page);
                        atomic_map = true;