wifi: mt76: mt7996: fix teardown command for an MLD peer

For an MLD peer, we only need to call the teardown command when removing
the last link, and there's no need to call mt7996_mcu_add_sta() for the
earlier links.

Fixes: c1d6dd5d03eb ("wifi: mt76: mt7996: Add mt7996_mcu_teardown_mld_sta rouine")
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Link: https://patch.msgid.link/20251106064203.1000505-6-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/main.c b/drivers/net/wireless/mediatek/mt76/mt7996/main.c
index 5e0b57657e7e4852e038d184debf5cd59dc05e24..685be98b9f2758a0a7bcff71a888e657116773a1 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7996/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c
@@ -1206,13 +1206,13 @@ mt7996_mac_sta_event(struct mt7996_dev *dev, struct ieee80211_vif *vif,
                                mt7996_mac_twt_teardown_flow(dev, link,
                                                             msta_link, i);
 
-                       if (sta->mlo && links == BIT(link_id)) /* last link */
-                               mt7996_mcu_teardown_mld_sta(dev, link,
-                                                           msta_link);
-                       else
+                       if (!sta->mlo)
                                mt7996_mcu_add_sta(dev, link_conf, link_sta,
                                                   link, msta_link,
                                                   CONN_STATE_DISCONNECT, false);
+                       else if (sta->mlo && links == BIT(link_id)) /* last link */
+                               mt7996_mcu_teardown_mld_sta(dev, link,
+                                                           msta_link);
                        msta_link->wcid.sta_disabled = 1;
                        msta_link->wcid.sta = 0;
                        links = links & ~BIT(link_id);