]> git.ipfire.org Git - thirdparty/iptables.git/commitdiff
Don't overwrite errno with return value of setsockopt (which is -1 on error).
authorPatrick McHardy <kaber@trash.net>
Sat, 22 Apr 2006 02:08:56 +0000 (02:08 +0000)
committerPatrick McHardy <kaber@trash.net>
Sat, 22 Apr 2006 02:08:56 +0000 (02:08 +0000)
Fixes "Unknown error 4294967295" message (bugzilla #460).

libiptc/libiptc.c

index 3538cca87aa6e979c212f9fb7c6b4424c94a9d21..794904b704d81d6bb85a0827d243f540c7a44dab 100644 (file)
@@ -2096,10 +2096,8 @@ TC_COMMIT(TC_HANDLE_T *handle)
 
        ret = setsockopt(sockfd, TC_IPPROTO, SO_SET_REPLACE, repl,
                         sizeof(*repl) + repl->size);
-       if (ret < 0) {
-               errno = ret;
+       if (ret < 0)
                goto out_free_newcounters;
-       }
 
        /* Put counters back. */
        strcpy(newcounters->name, (*handle)->info.name);
@@ -2190,10 +2188,8 @@ TC_COMMIT(TC_HANDLE_T *handle)
 
        ret = setsockopt(sockfd, TC_IPPROTO, SO_SET_ADD_COUNTERS,
                         newcounters, counterlen);
-       if (ret < 0) {
-               errno = ret;
+       if (ret < 0)
                goto out_free_newcounters;
-       }
 
        free(repl->counters);
        free(repl);