]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Fix accounting of offsets in unadjusted_ptr_and_unit_offset
authorJan Hubicka <hubicka@ucw.cz>
Mon, 22 Jul 2024 16:05:26 +0000 (18:05 +0200)
committerSam James <sam@gentoo.org>
Mon, 14 Oct 2024 19:52:29 +0000 (20:52 +0100)
unadjusted_ptr_and_unit_offset accidentally throws away the offset computed by
get_addr_base_and_unit_offset. Instead of passing extra_offset it passes offset.

PR ipa/114207

gcc/ChangeLog:

* ipa-prop.cc (unadjusted_ptr_and_unit_offset): Fix accounting of offsets in ADDR_EXPR.

gcc/testsuite/ChangeLog:

* gcc.c-torture/execute/pr114207.c: New test.

(cherry picked from commit 391f46f10b0586c074014de82efe76787739bb0c)

gcc/ipa-prop.cc
gcc/testsuite/gcc.c-torture/execute/pr114207.c [new file with mode: 0644]

index e2e83b5f3f50b04705c3049677b369bddbae6413..848d62e49cf9beb3fc3cedb75ef2a091158cf908 100644 (file)
@@ -1263,9 +1263,9 @@ unadjusted_ptr_and_unit_offset (tree op, tree *ret, poly_int64 *offset_ret)
     {
       if (TREE_CODE (op) == ADDR_EXPR)
        {
-         poly_int64 extra_offset = 0;
+         poly_int64 extra_offset;
          tree base = get_addr_base_and_unit_offset (TREE_OPERAND (op, 0),
-                                                    &offset);
+                                                    &extra_offset);
          if (!base)
            {
              base = get_base_address (TREE_OPERAND (op, 0));
diff --git a/gcc/testsuite/gcc.c-torture/execute/pr114207.c b/gcc/testsuite/gcc.c-torture/execute/pr114207.c
new file mode 100644 (file)
index 0000000..052fa85
--- /dev/null
@@ -0,0 +1,23 @@
+#include <stdio.h>
+#include <stdint.h>
+
+struct S {
+    int a, b;
+};
+
+__attribute__((noinline))
+void foo (struct S *s) {
+    struct S ss = (struct S) {
+        .a = s->b,
+        .b = s->a
+    };
+    *s = ss;
+}
+
+int main() {
+  struct S s = {6, 12};
+  foo(&s);
+  if (s.a != 12 || s.b != 6)
+    __builtin_abort ();
+  return 0;
+}