[COVERITY] Fix (error case) memory leak in blkid library (parse_dev)

Coverity ID: 29: Resource Leak

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

diff --git a/lib/blkid/ChangeLog b/lib/blkid/ChangeLog
index 919fbb01f33be52b91f7c7f4a81d3fe1106c7616..4433ef413d3bef5c15b7138641e004efd4796a11 100644 (file)
--- a/lib/blkid/ChangeLog
+++ b/lib/blkid/ChangeLog
@@ -1,3 +1,7 @@
+2007-03-23  Theodore Tso  <tytso@mit.edu>
+
+       * read.c (parse_dev): Fix memory leak on error path.
+
 2007-03-21  Theodore Tso  <tytso@mit.edu>
 
        * resolve.c (blkid_get_devname): Fix memory leak.

diff --git a/lib/blkid/read.c b/lib/blkid/read.c
index 7a147f69d6f311f6ce8dfd3c21cea8977c4e6fcb..583b54944fae7ef283bc362cc557a2a797d1c4d1 100644 (file)
--- a/lib/blkid/read.c
+++ b/lib/blkid/read.c
@@ -223,8 +223,10 @@ static int parse_dev(blkid_cache cache, blkid_dev *dev, char **cp)
 
        DBG(DEBUG_READ, printf("found dev %s\n", name));
 
-       if (!(*dev = blkid_get_dev(cache, name, BLKID_DEV_CREATE)))
+       if (!(*dev = blkid_get_dev(cache, name, BLKID_DEV_CREATE))) {
+               free(name);
                return -BLKID_ERR_MEM;
+       }
 
        free(name);
        return 1;