Fix memory leak in refresh_pattern parsing

Occurs when refresh_pattern is configure with invalid regex pattern.

 Detected by Coverity Scan. Issue 1058882.

diff --git a/src/cache_cf.cc b/src/cache_cf.cc
index 199881afa7658d83a7b5caf254181da5773223c4..3774f86d1224bd88181d22c713a4b4ad0c6225c5 100644 (file)
--- a/src/cache_cf.cc
+++ b/src/cache_cf.cc
@@ -2898,6 +2898,7 @@ parse_refreshpattern(RefreshPattern ** head)
         regerror(errcode, &comp, errbuf, sizeof errbuf);
         debugs(22, DBG_CRITICAL, "" << cfg_filename << " line " << config_lineno << ": " << config_input_line);
         debugs(22, DBG_CRITICAL, "refreshAddToList: Invalid regular expression '" << pattern << "': " << errbuf);
+        xfree(pattern);
         return;
     }