]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
powerpc/fsp2: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Fri, 9 Jan 2026 16:57:48 +0000 (17:57 +0100)
committerRob Herring (Arm) <robh@kernel.org>
Wed, 4 Feb 2026 02:58:13 +0000 (20:58 -0600)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
Link: https://patch.msgid.link/20260109-of-for-each-compatible-scoped-v3-4-c22fa2c0749a@oss.qualcomm.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
arch/powerpc/platforms/44x/fsp2.c

index f6b8d02e08b017398585e65bb82f3c48e64463eb..b06d9220844cc81ebbcd4b20f7ba8b321556547e 100644 (file)
@@ -199,16 +199,14 @@ static irqreturn_t rst_wrn_handler(int irq, void *data) {
 
 static void __init node_irq_request(const char *compat, irq_handler_t errirq_handler)
 {
-       struct device_node *np;
        unsigned int irq;
        int32_t rc;
 
-       for_each_compatible_node(np, NULL, compat) {
+       for_each_compatible_node_scoped(np, NULL, compat) {
                irq = irq_of_parse_and_map(np, 0);
                if (!irq) {
                        pr_err("device tree node %pOFn is missing a interrupt",
                              np);
-                       of_node_put(np);
                        return;
                }
 
@@ -216,7 +214,6 @@ static void __init node_irq_request(const char *compat, irq_handler_t errirq_han
                if (rc) {
                        pr_err("fsp_of_probe: request_irq failed: np=%pOF rc=%d",
                              np, rc);
-                       of_node_put(np);
                        return;
                }
        }