re PR c/61271 (10 * possible coding error with logical not (!))

	PR c/61271
	* ira-color.c (coalesced_pseudo_reg_slot_compare): Wrap LHS of
	a comparison in parens.
	* lra-spills.c (pseudo_reg_slot_compare): Wrap LHS of a comparison
	in parens.

From-SVN: r214359

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 0bdcef7d8b526a41f159356411b840300338408e..2b78565a070a296bf0f861f761ffea74fa69877b 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,11 @@
+2014-08-22  Marek Polacek  <polacek@redhat.com>
+
+       PR c/61271
+       * ira-color.c (coalesced_pseudo_reg_slot_compare): Wrap LHS of
+       a comparison in parens.
+       * lra-spills.c (pseudo_reg_slot_compare): Wrap LHS of a comparison
+       in parens.
+
 2014-08-22  David Malcolm  <dmalcolm@redhat.com>
 
        * rtl.h (fis_get_condition): Strengthen param "jump" from rtx to

diff --git a/gcc/ira-color.c b/gcc/ira-color.c
index 36c3c879f5757de701b743ce651e068176389af2..e2ea3596efcba8c993b9c061b2ae289ceea7984d 100644 (file)
--- a/gcc/ira-color.c
+++ b/gcc/ira-color.c
@@ -3850,7 +3850,7 @@ coalesced_pseudo_reg_slot_compare (const void *v1p, const void *v2p)
   slot_num2 = -ALLOCNO_HARD_REGNO (a2);
   if ((diff = slot_num1 - slot_num2) != 0)
     return (frame_pointer_needed
-           || !FRAME_GROWS_DOWNWARD == STACK_GROWS_DOWNWARD ? diff : -diff);
+           || (!FRAME_GROWS_DOWNWARD) == STACK_GROWS_DOWNWARD ? diff : -diff);
   total_size1 = MAX (PSEUDO_REGNO_BYTES (regno1),
                     regno_max_ref_width[regno1]);
   total_size2 = MAX (PSEUDO_REGNO_BYTES (regno2),

diff --git a/gcc/lra-spills.c b/gcc/lra-spills.c
index a6fb65bf75fe9353c628f60ddbc679f311e2cad5..8d494af38eb923513248a66638cd3f1112d031a6 100644 (file)
--- a/gcc/lra-spills.c
+++ b/gcc/lra-spills.c
@@ -237,7 +237,7 @@ pseudo_reg_slot_compare (const void *v1p, const void *v2p)
   slot_num2 = pseudo_slots[regno2].slot_num;
   if ((diff = slot_num1 - slot_num2) != 0)
     return (frame_pointer_needed
-           || !FRAME_GROWS_DOWNWARD == STACK_GROWS_DOWNWARD ? diff : -diff);
+           || (!FRAME_GROWS_DOWNWARD) == STACK_GROWS_DOWNWARD ? diff : -diff);
   total_size1 = GET_MODE_SIZE (lra_reg_info[regno1].biggest_mode);
   total_size2 = GET_MODE_SIZE (lra_reg_info[regno2].biggest_mode);
   if ((diff = total_size2 - total_size1) != 0)