]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Revert "securely wipe secret information in pairs"
authorAlan T. DeKok <aland@freeradius.org>
Thu, 27 Jul 2023 22:42:18 +0000 (15:42 -0700)
committerAlan T. DeKok <aland@freeradius.org>
Thu, 27 Jul 2023 22:42:18 +0000 (15:42 -0700)
This reverts commit d8ddfd4a1df33cfa21b942b20ce53af263b93c52.

nope.  Various Linux distributions don't have it.

src/include/build.h
src/lib/util/pair.c
src/lib/util/value.c

index 98a04de56398a90f7d2c4ae6cf559bd4f6a104c1..ec00bbc481807132a59ee0540245d6406e5b6328 100644 (file)
@@ -77,8 +77,6 @@ extern "C" {
  */
 #include <stdint.h>
 #include <stddef.h>
-
-#define __STDC_WANT_LIB_EXT1__ 1
 #include <string.h>
 
 /*
index 66b870258f09c2b40fdab7c3f027067720a7a3a2..2c52255ecc14bbb0612e732f9d836416d439df28 100644 (file)
@@ -87,13 +87,7 @@ static int _fr_pair_free(fr_pair_t *vp)
                fr_pair_list_free(&vp->vp_group);
                break;
 
-       case FR_TYPE_STRING:
-       case FR_TYPE_OCTETS:
-               if (vp->data.secret) (void) memset_s(vp->vp_ptr, vp->vp_length, 0, vp->vp_length);
-               break;
-
        default:
-               if (vp->data.secret) (void) memset_s(&vp->data, sizeof(vp->data), 0, sizeof(vp->data));
                break;
        }
 
index bfb4631685d5f83428cc719ba1886b0a6b6b0221..8ff187ea9f744b1bf319df797962879f8618ebc3 100644 (file)
@@ -3525,7 +3525,6 @@ void fr_value_box_clear_value(fr_value_box_t *data)
        switch (data->type) {
        case FR_TYPE_OCTETS:
        case FR_TYPE_STRING:
-               if (data->secret) (void) memset_s(data->datum.ptr, data->vb_length, 0, data->vb_length);
                talloc_free(data->datum.ptr);
                break;