]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
misc/ss: avoid NULL pointer dereference
authorPhil Sutter <phil@nwl.cc>
Thu, 6 Aug 2015 12:24:32 +0000 (14:24 +0200)
committerStephen Hemminger <shemming@brocade.com>
Wed, 12 Aug 2015 16:23:47 +0000 (09:23 -0700)
This was working before, but only if realloc a) succeeded and b) did not
move the buffer to a different location. ''**buf = **new_buf' then
writes the value of *new_buf's first field into that of *buf.

Signed-off-by: Phil Sutter <phil@nwl.cc>
misc/ss.c

index f59213b4ef595778b17e2651f53503221ec8e03e..d271b9506612d88d7b9225d304066a847748d094 100644 (file)
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -597,7 +597,7 @@ static int find_entry(unsigned ino, char **buf, int type)
                                        fprintf(stderr, "ss: failed to malloc buffer\n");
                                        abort();
                                }
-                               **buf = **new_buf;
+                               *buf = *new_buf;
                                buf_len = new_buf_len;
                                continue;
                        } else {