Bug 498318: Speed up field-descs.none.tmpl

Patch by Bradley Baetz <bbaetz@acm.org> r=mkanat, a=mkanat

diff --git a/Bugzilla/Template.pm b/Bugzilla/Template.pm
index 1362ecae3e32f4f672dea68da11095ddfb3230f1..261a8441a3400c444284601dc2de9748a4e75542 100644 (file)
--- a/Bugzilla/Template.pm
+++ b/Bugzilla/Template.pm
@@ -748,6 +748,14 @@ sub create {
             # Allow templates to generate a token themselves.
             'issue_hash_token' => \&Bugzilla::Token::issue_hash_token,
 
+            # A way for all templates to get at Field data, cached.
+            'bug_fields' => sub {
+                my $cache = Bugzilla->request_cache;
+                $cache->{template_bug_fields} ||= 
+                    { map { $_->name => $_ } Bugzilla->get_fields() };
+                return $cache->{template_bug_fields};
+            },
+
             # These don't work as normal constants.
             DB_MODULE        => \&Bugzilla::Constants::DB_MODULE,
             REQUIRED_MODULES => 

diff --git a/template/en/default/global/field-descs.none.tmpl b/template/en/default/global/field-descs.none.tmpl
index 344dc5528741621ffbef54aac1a10d9962d099f3..e2c04a0a6b62516cdc6fbc104efce8067fe6654a 100644 (file)
--- a/template/en/default/global/field-descs.none.tmpl
+++ b/template/en/default/global/field-descs.none.tmpl
@@ -92,7 +92,7 @@
 
 [% UNLESS Param('shutdownhtml') %]
   [% USE Bugzilla %]
-  [% FOREACH bz_field = Bugzilla.get_fields() %]
+  [% FOREACH bz_field = bug_fields.values %]
     [% SET field_descs.${bz_field.name} = bz_field.description
        IF !field_descs.${bz_field.name}.defined %]
   [% END %]