string/test-memcpy error reporting

http://sourceware.org/ml/libc-alpha/2013-08/msg00094.html

Using plain %s here runs the risk of segfaulting when displaying the
string.  src and dst aren't zero terminated strings.

	* string/test-memcpy.c (do_one_test): When reporting errors, print
	string address and don't overrun end of string.

diff --git a/ChangeLog b/ChangeLog
index 42607ea82214a6135d50d2ad34961c7f78b09419..a1c6f5ce1f84008364e493678aa55bc563158d21 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-10-04  Alan Modra  <amodra@gmail.com>
+
+       * string/test-memcpy.c (do_one_test): When reporting errors, print
+       string address and don't overrun end of string.
+
 2013-10-04  Alan Modra  <amodra@gmail.com>
 
        * sysdeps/powerpc/powerpc64/power7/memchr.S: Replace rlwimi with

diff --git a/string/test-memcpy.c b/string/test-memcpy.c
index d121ef02a5cab5d47a1562d9de769620da3a5044..b7ebe5f4e03bedd694d9020f224861816813f112 100644 (file)
--- a/string/test-memcpy.c
+++ b/string/test-memcpy.c
@@ -63,8 +63,8 @@ do_one_test (impl_t *impl, char *dst, const char *src,
 
   if (memcmp (dst, src, len) != 0)
     {
-      error (0, 0, "Wrong result in function %s dst \"%s\" src \"%s\"",
-            impl->name, dst, src);
+      error (0, 0, "Wrong result in function %s dst %p \"%.*s\" src %p \"%.*s\" len %zu",
+            impl->name, dst, (int) len, dst, src, (int) len, src, len);
       ret = 1;
       return;
     }