]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
usb: dwc3: keep susphy enabled during exit to avoid controller faults
authorUdipto Goswami <udipto.goswami@oss.qualcomm.com>
Wed, 26 Nov 2025 05:42:21 +0000 (11:12 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Dec 2025 13:49:18 +0000 (14:49 +0100)
On some platforms, switching USB roles from host to device can trigger
controller faults due to premature PHY power-down. This occurs when the
PHY is disabled too early during teardown, causing synchronization
issues between the PHY and controller.

Keep susphy enabled during dwc3_host_exit() and dwc3_gadget_exit()
ensures the PHY remains in a low-power state capable of handling
required commands during role switch.

Cc: stable <stable@kernel.org>
Fixes: 6d735722063a ("usb: dwc3: core: Prevent phy suspend during init")
Suggested-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Signed-off-by: Udipto Goswami <udipto.goswami@oss.qualcomm.com>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://patch.msgid.link/20251126054221.120638-1-udipto.goswami@oss.qualcomm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/gadget.c
drivers/usb/dwc3/host.c

index bc3fe31638b9a006f26421c7c0dcc25e7b2be64a..8a35a6901db7d750a8abf05339a19c30bad2b7bb 100644 (file)
@@ -4826,7 +4826,7 @@ void dwc3_gadget_exit(struct dwc3 *dwc)
        if (!dwc->gadget)
                return;
 
-       dwc3_enable_susphy(dwc, false);
+       dwc3_enable_susphy(dwc, true);
        usb_del_gadget(dwc->gadget);
        dwc3_gadget_free_endpoints(dwc);
        usb_put_gadget(dwc->gadget);
index cf6512ed17a69134e6ca1b884f76c1439693fab1..96b588bd08cdce03302688949679fcf756c8ff2d 100644 (file)
@@ -227,7 +227,7 @@ void dwc3_host_exit(struct dwc3 *dwc)
        if (dwc->sys_wakeup)
                device_init_wakeup(&dwc->xhci->dev, false);
 
-       dwc3_enable_susphy(dwc, false);
+       dwc3_enable_susphy(dwc, true);
        platform_device_unregister(dwc->xhci);
        dwc->xhci = NULL;
 }