]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vz: fix memory leaks in prlsdkLoadDomains
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Wed, 8 Jun 2016 07:17:21 +0000 (10:17 +0300)
committerMaxim Nestratov <mnestratov@virtuozzo.com>
Mon, 18 Jul 2016 19:20:51 +0000 (22:20 +0300)
Free sdkdom on any result of prlsdkNewDomainByHandle.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
src/vz/vz_sdk.c

index 41895cddba7823a5af4c678410576c947dcb8117..2ead9f2b90e0cd606087f6d6e6291f9d01003b2e 100644 (file)
@@ -1810,10 +1810,9 @@ prlsdkLoadDomains(vzDriverPtr driver)
         pret = PrlResult_GetParamByIndex(result, i, &sdkdom);
         prlsdkCheckRetGoto(pret, error);
 
-        if (!(dom = prlsdkNewDomainByHandle(driver, sdkdom)))
-            continue;
+        if ((dom = prlsdkNewDomainByHandle(driver, sdkdom)))
+            virObjectUnlock(dom);
 
-        virObjectUnlock(dom);
         PrlHandle_Free(sdkdom);
         sdkdom = PRL_INVALID_HANDLE;
     }