]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
Compile tst-prelink.c without PIE [BZ #21815]
authorH.J. Lu <hjl.tools@gmail.com>
Fri, 4 Aug 2017 19:58:01 +0000 (12:58 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Fri, 4 Aug 2017 19:58:13 +0000 (12:58 -0700)
tst-prelink.c checks for conflict with GLOB_DAT relocation against stdio.
On i386, there is no GLOB_DAT relocation against stdio with PIE.  We
should compile tst-prelink.c without PIE.

[BZ #21815]
* elf/Makefile (CFLAGS-tst-prelink.c): New.
(LDFLAGS-tst-prelink): Likewise.

ChangeLog
elf/Makefile

index 6a50d235f59830c086a006e332fb895b70927c12..8291f6e05b5fef597a9524efe7e05c6aa4b6366e 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2017-08-04  H.J. Lu  <hongjiu.lu@intel.com>
+
+       [BZ #21815]
+       * elf/Makefile (CFLAGS-tst-prelink.c): New.
+       (LDFLAGS-tst-prelink): Likewise.
+
 2017-08-04  H.J. Lu  <hongjiu.lu@intel.com>
 
        * sysdeps/unix/sysv/linux/i386/sysdep.h (I386_USE_SYSENTER):
index 2956445de88885263d1da513e702e3c29206dc1e..828daaa0be7816cfe59cc1108b1d0890f9a84156 100644 (file)
@@ -358,6 +358,9 @@ update-all-abi: update-all-abi-ld
 
 ifeq ($(have-glob-dat-reloc),yes)
 tests += tst-prelink
+# Don't compile tst-prelink.c with PIE for GLOB_DAT relocation.
+CFLAGS-tst-prelink.c += -fno-pie
+LDFLAGS-tst-prelink = $(no-pie-ldflag)
 ifeq ($(run-built-tests),yes)
 tests-special += $(objpfx)tst-prelink-cmp.out
 endif