vdpa/octeon_ep: Fix error code in octep_process_mbox()

Return -EINVAL for invalid signatures.  Don't return success.

Fixes: 8b6c724cdab8 ("virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Message-Id: <623e885b-1a05-479e-ab97-01bcf10bf5b8@stanley.mountain>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
index 7fa0491bb201eb320faa5e947b55035642af0112..11bd76ae18cf937c5dd25ec7c000abe7a4b5c130 100644 (file)
--- a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
+++ b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c
@@ -140,7 +140,7 @@ static int octep_process_mbox(struct octep_hw *oct_hw, u16 id, u16 qid, void *bu
        val = octep_read_sig(mbox);
        if ((val & 0xFFFF) != MBOX_RSP_SIG) {
                dev_warn(&pdev->dev, "Invalid Signature from mbox : %d response\n", id);
-               return ret;
+               return -EINVAL;
        }
 
        val = octep_read_sts(mbox);