clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains()

[ Upstream commit 81a206d736c19139d3863b79e7174f9e98b45499 ]

If device_link_add() fails, it returns NULL pointer not ERR_PTR(),
replace IS_ERR() with NULL pointer check, and return -EINVAL.

Fixes: d3a0946d7ac9 ("clk: imx: imx8: add audio clock mux driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20241026112452.1523-1-yangyingliang@huaweicloud.com
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c
index 1bdb480cc96c6bd7c4dc2a0a8c46e2024b36f0cd..37c61d10f213ce831a27f4e9a596300afba88dc3 100644 (file)
--- a/drivers/clk/imx/clk-imx8-acm.c
+++ b/drivers/clk/imx/clk-imx8-acm.c
@@ -289,9 +289,9 @@ static int clk_imx_acm_attach_pm_domains(struct device *dev,
                                                         DL_FLAG_STATELESS |
                                                         DL_FLAG_PM_RUNTIME |
                                                         DL_FLAG_RPM_ACTIVE);
-               if (IS_ERR(dev_pm->pd_dev_link[i])) {
+               if (!dev_pm->pd_dev_link[i]) {
                        dev_pm_domain_detach(dev_pm->pd_dev[i], false);
-                       ret = PTR_ERR(dev_pm->pd_dev_link[i]);
+                       ret = -EINVAL;
                        goto detach_pm;
                }
        }