Remove the VP from the cursor before freeing

That way the cursor doesn't contain references to already freed memory.

diff --git a/src/lib/util/pair.c b/src/lib/util/pair.c
index e16b327cb9372247347668ef9bea49382ea2ddb3..594cd2966cd6fccd90fdf44bcdea0a7eafc586e7 100644 (file)
--- a/src/lib/util/pair.c
+++ b/src/lib/util/pair.c
@@ -538,13 +538,10 @@ void fr_pair_list_free(VALUE_PAIR **vps)
        VALUE_PAIR      *vp;
        fr_cursor_t     cursor;
 
-       if (!vps || !*vps) {
-               return;
-       }
+       if (!vps || !*vps) return;
 
-       for (vp = fr_cursor_init(&cursor, vps);
-            vp;
-            vp = fr_cursor_next(&cursor)) {
+       fr_cursor_init(&cursor, vps);
+       while ((vp = fr_cursor_remove(&cursor))) {
                VP_VERIFY(vp);
                talloc_free(vp);
        }