]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: fec: make FIXED_PHY dependency unconditional
authorArnd Bergmann <arnd@arndb.de>
Thu, 2 Apr 2026 14:10:40 +0000 (16:10 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 3 Apr 2026 21:39:37 +0000 (14:39 -0700)
When CONFIG_FIXED_PHY is in a loadable module, the fec driver cannot be
built-in any more:

x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe':
fec_main.c:(.text+0xc4f367): undefined reference to `fixed_phy_unregister'
x86_64-linux-ld: vmlinux.o: in function `fec_enet_close':
fec_main.c:(.text+0xc59591): undefined reference to `fixed_phy_unregister'
x86_64-linux-ld: vmlinux.o: in function `fec_enet_mii_probe.cold':

Select the fixed phy support on all targets to make this build
correctly, not just on coldfire.

Notat that Essentially the stub helpers in include/linux/phy_fixed.h
cannot be used correctly because of this build time dependency,
and we could just remove them to hit the build failure more often
when a driver uses them without the 'select FIXED_PHY'.

Fixes: dc86b621e1b4 ("net: fec: register a fixed phy using fixed_phy_register_100fd if needed")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260402141048.2713445-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/Kconfig

index e2a591cf9601f2f54ff99ce2e59f2f18a4857945..11edbb46a1180d4dc0abc90202e316b7be51098f 100644 (file)
@@ -28,7 +28,7 @@ config FEC
        depends on PTP_1588_CLOCK_OPTIONAL
        select CRC32
        select PHYLIB
-       select FIXED_PHY if M5272
+       select FIXED_PHY
        select PAGE_POOL
        imply PAGE_POOL_STATS
        imply NET_SELFTESTS