file generated by alembic revison is now pep8 compliant

Change-Id: I233d2ba2cbbe6a363d9118182f1d855a6a12b00c
Pull-request: https://github.com/zzzeek/alembic/pull/31

diff --git a/alembic/templates/generic/script.py.mako b/alembic/templates/generic/script.py.mako
index 8f45a34e00df17640107a7e8e33ec4accc01e2fd..2c0156303a8df3ffdc9de87765bf801bf6bea4a5 100644 (file)
--- a/alembic/templates/generic/script.py.mako
+++ b/alembic/templates/generic/script.py.mako
@@ -15,6 +15,7 @@ down_revision = ${repr(down_revision)}
 branch_labels = ${repr(branch_labels)}
 depends_on = ${repr(depends_on)}
 
+
 def upgrade():
     ${upgrades if upgrades else "pass"}
 

diff --git a/alembic/testing/env.py b/alembic/testing/env.py
index 91c7fa539bb4ef914afe973abb3867cc04aa826f..5ad6c694e985230a6785be3629b19c8f9e77ab53 100644 (file)
--- a/alembic/testing/env.py
+++ b/alembic/testing/env.py
@@ -257,9 +257,11 @@ down_revision = None
 
 from alembic import op
 
+
 def upgrade():
     op.execute("CREATE STEP 1")
 
+
 def downgrade():
     op.execute("DROP STEP 1")
 
@@ -273,9 +275,11 @@ down_revision = '%s'
 
 from alembic import op
 
+
 def upgrade():
     op.execute("CREATE STEP 2")
 
+
 def downgrade():
     op.execute("DROP STEP 2")
 
@@ -289,9 +293,11 @@ down_revision = '%s'
 
 from alembic import op
 
+
 def upgrade():
     op.execute("CREATE STEP 3")
 
+
 def downgrade():
     op.execute("DROP STEP 3")
 

diff --git a/docs/build/changelog.rst b/docs/build/changelog.rst
index f10a61ea96aef5e50bbdbd45f1d54b6878db3a01..b78eaa7bfaf907d1ff2936717c0b65743d8a1ba5 100644 (file)
--- a/docs/build/changelog.rst
+++ b/docs/build/changelog.rst
@@ -6,6 +6,14 @@ Changelog
 .. changelog::
     :version: 0.8.9
 
+    .. change::
+      :tags: bug, autogenerate
+      :tickets: 393
+
+      Continued pep8 improvements by adding appropriate whitespace in
+      the base template for generated migrations.  Pull request courtesy
+      Markus Mattes.
+
     .. change::
       :tags: bug, revisioning
 

diff --git a/tests/test_postgresql.py b/tests/test_postgresql.py
index d39df72bd368259c90c23ea4492d15d73a568be1..21479a06d15b39b61e43516dbac0474f18e8f12a 100644 (file)
--- a/tests/test_postgresql.py
+++ b/tests/test_postgresql.py
@@ -90,11 +90,13 @@ from alembic import op
 from sqlalchemy.dialects.postgresql import ENUM
 from sqlalchemy import Column
 
+
 def upgrade():
     op.create_table("sometable",
         Column("data", ENUM("one", "two", "three", name="pgenum"))
     )
 
+
 def downgrade():
     op.drop_table("sometable")
 """ % self.rid)
@@ -108,6 +110,7 @@ from alembic import op
 from sqlalchemy.dialects.postgresql import ENUM
 from sqlalchemy import Column
 
+
 def upgrade():
     enum = ENUM("one", "two", "three", name="pgenum", create_type=False)
     enum.create(op.get_bind(), checkfirst=False)
@@ -115,6 +118,7 @@ def upgrade():
         Column("data", enum)
     )
 
+
 def downgrade():
     op.drop_table("sometable")
     ENUM(name="pgenum").drop(op.get_bind(), checkfirst=False)

diff --git a/tests/test_script_consumption.py b/tests/test_script_consumption.py
index c2eef0a2b125896b4e286290959cf52c56905fe9..fc9d9aa01da3923301f38d2043e3498bf859c0b8 100644 (file)
--- a/tests/test_script_consumption.py
+++ b/tests/test_script_consumption.py
@@ -47,9 +47,11 @@ class ApplyVersionsFunctionalTest(TestBase):
 
     from alembic import op
 
+
     def upgrade():
         op.execute("CREATE TABLE foo(id integer)")
 
+
     def downgrade():
         op.execute("DROP TABLE foo")
 
@@ -62,9 +64,11 @@ class ApplyVersionsFunctionalTest(TestBase):
 
     from alembic import op
 
+
     def upgrade():
         op.execute("CREATE TABLE bar(id integer)")
 
+
     def downgrade():
         op.execute("DROP TABLE bar")
 
@@ -77,9 +81,11 @@ class ApplyVersionsFunctionalTest(TestBase):
 
     from alembic import op
 
+
     def upgrade():
         op.execute("CREATE TABLE bat(id integer)")
 
+
     def downgrade():
         op.execute("DROP TABLE bat")
 
@@ -221,9 +227,11 @@ class VersionNameTemplateTest(TestBase):
 
     from alembic import op
 
+
     def upgrade():
         op.execute("CREATE TABLE foo(id integer)")
 
+
     def downgrade():
         op.execute("DROP TABLE foo")
 
@@ -244,9 +252,11 @@ class VersionNameTemplateTest(TestBase):
 
     from alembic import op
 
+
     def upgrade():
         op.execute("CREATE TABLE foo(id integer)")
 
+
     def downgrade():
         op.execute("DROP TABLE foo")
 
@@ -270,11 +280,14 @@ down_revision = None
 
 from alembic import op
 
+
 def upgrade():
     op.execute("CREATE TABLE foo(id integer)")
 
+
 def downgrade():
     op.execute("DROP TABLE foo")
+
 """)
         pyc_path = util.pyc_file_from_path(path)
         if os.access(pyc_path, os.F_OK):
@@ -350,9 +363,11 @@ class SourcelessNeedsFlagTest(TestBase):
 
     from alembic import op
 
+
     def upgrade():
         op.execute("CREATE TABLE foo(id integer)")
 
+
     def downgrade():
         op.execute("DROP TABLE foo")
 

diff --git a/tests/test_script_production.py b/tests/test_script_production.py
index d32a94c7491784f6ea9711f1b0a961c87e2202e1..7cabc773b02862c76fa32f379be1bf63ea07eb3a 100644 (file)
--- a/tests/test_script_production.py
+++ b/tests/test_script_production.py
@@ -201,7 +201,7 @@ class RevisionCommandTest(TestBase):
             file_.write(
                 "<%text>#</%text> ${message}\n"
                 "revision = ${repr(up_revision)}\n"
-                "down_revision = ${repr(down_revision)}\n"
+                "down_revision = ${repr(down_revision)}\n\n"
                 "def upgrade():\n"
                 "    ${upgrades if upgrades else 'pass'}\n\n"
                 "def downgrade():\n"
@@ -252,9 +252,11 @@ branch_labels = ['%s']
 
 from alembic import op
 
+
 def upgrade():
     pass
 
+
 def downgrade():
     pass
 
@@ -870,9 +872,11 @@ branch_labels = ['%s']
 
 from alembic import op
 
+
 def upgrade():
     pass
 
+
 def downgrade():
     pass