]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: qcom: sdm845-shift-axolotl: fix touchscreen properties
authorJoel Selvaraj <foss@joelselvaraj.com>
Tue, 21 Oct 2025 06:20:49 +0000 (01:20 -0500)
committerBjorn Andersson <andersson@kernel.org>
Mon, 27 Oct 2025 18:26:58 +0000 (13:26 -0500)
The touchscreen properties previously upstreamed was based on downstream
touchscreen driver. We ended up adapting upstream edt_ft5x06 driver to
support the touchscreen controller used in this device. Update the
touchscreen properties to match with the upstream edt_ft5x06
driver.

Also, the touchscreen controller used in this device is ft5452 and not
fts8719. Fix the compatible string accordingly.

The wakeup-source property was removed as it prevents the touchscreen's
regulators and irq from being disabled when the device is suspended and
could lead to unexpected battery drain. Once low power mode and
tap-to-wake functionality is properly implemented and tested to be
working, we can add it back, if needed.

Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20251021-shift-axolotl-fix-touchscreen-dts-v2-1-e94727f0aa7e@joelselvaraj.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts

index 46ca4a38a9a898b726517831f165da399ba2bfe0..f0ae0159f32a05edc376007d1d792e70a51a0db5 100644 (file)
        status = "okay";
 
        touchscreen@38 {
-               compatible = "focaltech,fts8719";
+               compatible = "focaltech,ft5452";
                reg = <0x38>;
-               wakeup-source;
-               interrupt-parent = <&tlmm>;
-               interrupts = <125 IRQ_TYPE_EDGE_FALLING>;
-               vdd-supply = <&vreg_l28a_3p0>;
-               vcc-i2c-supply = <&vreg_l14a_1p88>;
 
-               pinctrl-names = "default", "suspend";
+               interrupts-extended = <&tlmm 125 IRQ_TYPE_EDGE_FALLING>;
+               reset-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
+
+               vcc-supply = <&vreg_l28a_3p0>;
+               iovcc-supply = <&vreg_l14a_1p88>;
+
                pinctrl-0 = <&ts_int_active &ts_reset_active>;
                pinctrl-1 = <&ts_int_suspend &ts_reset_suspend>;
+               pinctrl-names = "default", "suspend";
 
-               reset-gpio = <&tlmm 99 GPIO_ACTIVE_HIGH>;
-               irq-gpio = <&tlmm 125 GPIO_TRANSITORY>;
                touchscreen-size-x = <1080>;
                touchscreen-size-y = <2160>;
        };