]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Ignore softhsm2 errors when deleting token in keyfromlabel test
authorNicki Křížek <nicki@isc.org>
Thu, 19 Jun 2025 13:09:39 +0000 (15:09 +0200)
committerNicki Křížek <nicki@isc.org>
Thu, 19 Jun 2025 13:52:16 +0000 (13:52 +0000)
In some rare cases, the softhsm2 utility reports failure to delete the
token directory, despite the token being found. Subsequent attempts to
delete the token again indicate that the token was deleted.

Ignore this cleanup error, as it doesn't prevent our tests from working
properly. There is also an attempt to delete the token before the test
starts which ensures a clean state before the test is executed, in case
there's actually a leftover token.

(cherry picked from commit e786a2e950411fb3ffe1aed140cc4520e4ffd74a)

bin/tests/system/keyfromlabel/tests_keyfromlabel.py

index f53191544289b8c95a1f6ad264893045b4bd7d1d..428717d5a2a745508acef957732bb3b32aeec3c1 100644 (file)
@@ -70,7 +70,7 @@ def token_init_and_cleanup():
     isctest.run.cmd(
         token_cleanup_command,
         env=EMPTY_OPENSSL_CONF_ENV,
-        log_stderr=False,
+        log_stdout=True,
         raise_on_exception=False,
     )
 
@@ -82,7 +82,10 @@ def token_init_and_cleanup():
         yield
     finally:
         output = isctest.run.cmd(
-            token_cleanup_command, env=EMPTY_OPENSSL_CONF_ENV, log_stdout=True
+            token_cleanup_command,
+            env=EMPTY_OPENSSL_CONF_ENV,
+            log_stdout=True,
+            raise_on_exception=False,
         ).stdout.decode("utf-8")
         assert re.search("Found token (.*) with matching token label", output)
         assert re.search("The token (.*) has been deleted", output)