]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/chrome: cros_typec_switch: Don't touch struct fwnode_handle::dev
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 20 Jan 2026 13:12:30 +0000 (14:12 +0100)
committerTzung-Bi Shih <tzungbi@kernel.org>
Wed, 21 Jan 2026 04:36:56 +0000 (04:36 +0000)
The 'dev' field in struct fwnode is special and related to device links,
There no driver should use it for printing messages. Fix incorrect use
of private field.

Fixes: affc804c44c8 ("platform/chrome: cros_typec_switch: Add switch driver")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20260120131413.1697891-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
drivers/platform/chrome/cros_typec_switch.c

index 8d7c34abb0a1282dd72bb6d7c5ff56e168dec713..d8a28d4e51a85eb694e2e93dcca603d8ae64a04e 100644 (file)
@@ -230,20 +230,20 @@ static int cros_typec_register_switches(struct cros_typec_switch_data *sdata)
 
                adev = to_acpi_device_node(fwnode);
                if (!adev) {
-                       dev_err(fwnode->dev, "Couldn't get ACPI device handle\n");
+                       dev_err(dev, "Couldn't get ACPI device handle for %pfwP\n", fwnode);
                        ret = -ENODEV;
                        goto err_switch;
                }
 
                ret = acpi_evaluate_integer(adev->handle, "_ADR", NULL, &index);
                if (ACPI_FAILURE(ret)) {
-                       dev_err(fwnode->dev, "_ADR wasn't evaluated\n");
+                       dev_err(dev, "_ADR wasn't evaluated for %pfwP\n", fwnode);
                        ret = -ENODATA;
                        goto err_switch;
                }
 
                if (index >= EC_USB_PD_MAX_PORTS) {
-                       dev_err(fwnode->dev, "Invalid port index number: %llu\n", index);
+                       dev_err(dev, "%pfwP: Invalid port index number: %llu\n", fwnode, index);
                        ret = -EINVAL;
                        goto err_switch;
                }