pool: fix compiler warning

clang-4.0 reported:

util-pool.c:242:13: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
        if (! pb->flags & POOL_BUCKET_PREALLOCATED) {
            ^           ~
util-pool.c:242:13: note: add parentheses after the '!' to evaluate the bitwise operator first
        if (! pb->flags & POOL_BUCKET_PREALLOCATED) {
            ^
              (                                   )
util-pool.c:242:13: note: add parentheses around left hand side expression to silence this warning
        if (! pb->flags & POOL_BUCKET_PREALLOCATED) {
            ^
            (          )
util-pool.c:261:13: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
        if (! pb->flags & POOL_BUCKET_PREALLOCATED) {
            ^           ~
util-pool.c:261:13: note: add parentheses after the '!' to evaluate the bitwise operator first
        if (! pb->flags & POOL_BUCKET_PREALLOCATED) {
            ^
              (                                   )
util-pool.c:261:13: note: add parentheses around left hand side expression to silence this warning
        if (! pb->flags & POOL_BUCKET_PREALLOCATED) {
            ^
            (          )
2 warnings generated.

diff --git a/src/util-pool.c b/src/util-pool.c
index dc536df7fff269b83846005f0db34557ee80a215..4706222d8df203ac3b56c8f481c5f085d72b0b81 100644 (file)
--- a/src/util-pool.c
+++ b/src/util-pool.c
@@ -239,7 +239,7 @@ void PoolFree(Pool *p)
                 SCFree(pb->data);
         }
         pb->data = NULL;
-        if (! pb->flags & POOL_BUCKET_PREALLOCATED) {
+        if (!(pb->flags & POOL_BUCKET_PREALLOCATED)) {
             SCFree(pb);
         }
     }
@@ -258,7 +258,7 @@ void PoolFree(Pool *p)
             }
             pb->data = NULL;
         }
-        if (! pb->flags & POOL_BUCKET_PREALLOCATED) {
+        if (!(pb->flags & POOL_BUCKET_PREALLOCATED)) {
             SCFree(pb);
         }
     }