]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3/libsmb: clang: Fix 'The left operand of '>' or '<' is a garbage value
authorNoel Power <noel.power@suse.com>
Wed, 14 Aug 2019 13:42:06 +0000 (14:42 +0100)
committerGary Lockyer <gary@samba.org>
Tue, 27 Aug 2019 23:04:37 +0000 (23:04 +0000)
Fixes:

source3/libsmb/clireadwrite.c:601:15: warning: The left operand of '>' is a garbage value <--[clang]
        if (received > expected) {

source3/libsmb/clireadwrite.c:799:16: warning: The left operand of '<' is a garbage value <--[clang]
        if ((received < 0) || (received > state->buflen)) {
             ~~~~~~~~ ^

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
source3/libsmb/clireadwrite.c

index da188db7c3176db8b24eb021a7487d2da0178ede..5ee202ebf4ec361d77158f4d399205d884626b9d 100644 (file)
@@ -580,7 +580,7 @@ static void cli_pull_chunk_done(struct tevent_req *subreq)
                struct cli_pull_state);
        NTSTATUS status;
        size_t expected = chunk->total_size - chunk->tmp_size;
-       ssize_t received;
+       ssize_t received = 0;
        uint8_t *buf = NULL;
 
        chunk->subreq = NULL;