]> git.ipfire.org Git - thirdparty/sqlalchemy/alembic.git/commitdiff
- [bug] Fixed the generation of CHECK constraint,
authorMike Bayer <mike_mp@zzzcomputing.com>
Tue, 31 Jan 2012 15:08:12 +0000 (10:08 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 31 Jan 2012 15:08:12 +0000 (10:08 -0500)
  regression from 0.2.0 [#26]

CHANGES
alembic/__init__.py
alembic/autogenerate.py
tests/test_autogenerate.py

diff --git a/CHANGES b/CHANGES
index 273667a6b9ee7538d420f13a2fc23305f00965d2..eaea5ca6939e6030f0889fbad7c411c10943c37f 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,8 @@
+0.2.1
+=====
+- [bug] Fixed the generation of CHECK constraint,
+  regression from 0.2.0 [#26]
+
 0.2.0
 =====
 - [feature] API rearrangement allows everything
index dd0591ec0bd9060e4b20e7a51699430c353aa29b..500a414dab2278d24a85f0379642faace0581be8 100644 (file)
@@ -1,6 +1,6 @@
 from os import path
 
-__version__ = '0.2.0'
+__version__ = '0.2.1'
 
 package_dir = path.abspath(path.dirname(__file__))
 
index d90114a398db73de003f819b8544ca9175f79be5..8fc51920b7da99733c11ab81f6b4f806ce245578 100644 (file)
@@ -454,7 +454,7 @@ def _render_foreign_key(constraint, autogen_context):
         ),
     }
 
-def _render_check_constraint(constraint):
+def _render_check_constraint(constraint, autogen_context):
     opts = []
     if constraint.name:
         opts.append(("name", repr(constraint.name)))
index 264dc06c101dba22e23e42116d20fa2fa7d5f242..497ceb210dc58307a8318c60c5f2944082e62384 100644 (file)
@@ -1,5 +1,5 @@
 from sqlalchemy import MetaData, Column, Table, Integer, String, Text, \
-    Numeric, CHAR, ForeignKey, DATETIME, TypeDecorator
+    Numeric, CHAR, ForeignKey, DATETIME, TypeDecorator, CheckConstraint
 from sqlalchemy.types import NULLTYPE
 from sqlalchemy.engine.reflection import Inspector
 from alembic import autogenerate
@@ -65,6 +65,7 @@ def _model_two():
         Column('id', Integer, primary_key=True),
         Column('description', String(100)),
         Column('order_id', Integer, ForeignKey('order.order_id')),
+        CheckConstraint('len(description) > 5')
     )
     return m
 
@@ -182,6 +183,7 @@ class AutogenerateDiffTest(TestCase):
     sa.Column('id', sa.Integer(), nullable=False),
     sa.Column('description', sa.String(length=100), nullable=True),
     sa.Column('order_id', sa.Integer(), nullable=True),
+    sa.CheckConstraint('TODO'),
     sa.ForeignKeyConstraint(['order_id'], ['order.order_id'], ),
     sa.PrimaryKeyConstraint('id')
     )