]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virsh: Remove needless variable
authorMartin Kletzander <mkletzan@redhat.com>
Tue, 16 Nov 2021 13:30:07 +0000 (14:30 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Tue, 23 Nov 2021 11:51:09 +0000 (12:51 +0100)
It only redundantly reflects whether pkagent != NULL.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
tools/virsh.c

index b9f3f851d3ec39baf0b39ad1b2f0dfc8fe36a604..da35c5c2b9c1c3ae92aeb5ef6126f4631efd0b05 100644 (file)
@@ -119,7 +119,6 @@ virshConnect(vshControl *ctl, const char *uri, bool readonly)
     bool keepalive_forced = false;
     virPolkitAgent *pkagent = NULL;
     int authfail = 0;
-    bool agentCreated = false;
 
     if (ctl->keepalive_interval >= 0) {
         interval = ctl->keepalive_interval;
@@ -141,12 +140,11 @@ virshConnect(vshControl *ctl, const char *uri, bool readonly)
             goto cleanup;
 
         err = virGetLastError();
-        if (!agentCreated &&
+        if (!pkagent &&
             err && err->domain == VIR_FROM_POLKIT &&
             err->code == VIR_ERR_AUTH_UNAVAILABLE) {
-            if (!pkagent && !(pkagent = virPolkitAgentCreate()))
+            if (!(pkagent = virPolkitAgentCreate()))
                 goto cleanup;
-            agentCreated = true;
         } else if (err && err->domain == VIR_FROM_POLKIT &&
                    err->code == VIR_ERR_AUTH_FAILED) {
             authfail++;