]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-dhcp6-client: logs invalid NTP option
authorYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 10 Feb 2022 12:11:32 +0000 (21:11 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 14 Feb 2022 06:02:33 +0000 (15:02 +0900)
Returning negative errno triggers to produce debugging log in
dhcp6_lease_parse_message().

src/libsystemd-network/sd-dhcp6-lease.c

index 90adad16a6a0165c30f3893f52d38245e88cb0a8..941de2f68cc2f930ace79004a06153b13c643850 100644 (file)
@@ -345,7 +345,7 @@ int dhcp6_lease_add_ntp(sd_dhcp6_lease *lease, const uint8_t *optval, size_t opt
                 case DHCP6_NTP_SUBOPTION_SRV_ADDR:
                 case DHCP6_NTP_SUBOPTION_MC_ADDR:
                         if (sublen != 16)
-                                return 0;
+                                return -EINVAL;
 
                         r = dhcp6_option_parse_addresses(subval, sublen, &lease->ntp, &lease->ntp_count);
                         if (r < 0)