]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Annotate false positive tainted data in fr_udp_header_check() (CID #1504068) (#4728)
authorJames Jones <jejones3141@gmail.com>
Wed, 21 Sep 2022 13:53:21 +0000 (08:53 -0500)
committerGitHub <noreply@github.com>
Wed, 21 Sep 2022 13:53:21 +0000 (09:53 -0400)
Coverity doesn't recognize the check that diff == 0 as a check of
udp_len.

src/lib/util/net.c

index ca36d6f5561acffd7dcc6a504e271475a1e5f74b..11822f26fd88939bee7503d48af39cf9e591b5ed 100644 (file)
@@ -89,6 +89,7 @@ size_t fr_net_af_table_len = NUM_ELEMENTS(fr_net_af_table);
                return -1;
        }
 
+       /* coverity[tainted_data] */
        expected = fr_udp_checksum((uint8_t const *) udp, udp_len, udp->checksum,
                                   ip->ip_src, ip->ip_dst);
        if (udp->checksum != expected) {