]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: imx-card: Add NULL check in imx_card_probe()
authorHenry Martin <bsdhenrymartin@gmail.com>
Tue, 1 Apr 2025 14:25:10 +0000 (22:25 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Apr 2025 12:37:39 +0000 (14:37 +0200)
[ Upstream commit 93d34608fd162f725172e780b1c60cc93a920719 ]

devm_kasprintf() returns NULL when memory allocation fails. Currently,
imx_card_probe() does not check for this case, which results in a NULL
pointer dereference.

Add NULL check after devm_kasprintf() to prevent this issue.

Fixes: aa736700f42f ("ASoC: imx-card: Add imx-card machine driver")
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20250401142510.29900-1-bsdhenrymartin@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/fsl/imx-card.c

index f8144bf4c90d33d2a20ba934be4cc3c423077ac4..7128bcf3a743e1c4845bb95e15247a273f97f50b 100644 (file)
@@ -742,6 +742,8 @@ static int imx_card_probe(struct platform_device *pdev)
                                data->dapm_routes[i].sink =
                                        devm_kasprintf(&pdev->dev, GFP_KERNEL, "%d %s",
                                                       i + 1, "Playback");
+                               if (!data->dapm_routes[i].sink)
+                                       return -ENOMEM;
                                data->dapm_routes[i].source = "CPU-Playback";
                        }
                }
@@ -759,6 +761,8 @@ static int imx_card_probe(struct platform_device *pdev)
                                data->dapm_routes[i].source =
                                        devm_kasprintf(&pdev->dev, GFP_KERNEL, "%d %s",
                                                       i + 1, "Capture");
+                               if (!data->dapm_routes[i].source)
+                                       return -ENOMEM;
                                data->dapm_routes[i].sink = "CPU-Capture";
                        }
                }