btrfs: zoned: fixup last alloc pointer after extent removal for DUP

When a block group is composed of a sequential write zone and a
conventional zone, we recover the (pseudo) write pointer of the
conventional zone using the end of the last allocated position.

However, if the last extent in a block group is removed, the last extent
position will be smaller than the other real write pointer position.
Then, that will cause an error due to mismatch of the write pointers.

We can fixup this case by moving the alloc_offset to the corresponding
write pointer position.

Fixes: c0d90a79e8e6 ("btrfs: zoned: fix alloc_offset calculation for partly conventional block groups")
CC: stable@vger.kernel.org # 6.16+
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 714f45045c84fd224860b1265e98860e5f79c201..a10e1076c881608ffd69b1da28fcadf5262910ac 100644 (file)
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -1450,6 +1450,20 @@ static int btrfs_load_block_group_dup(struct btrfs_block_group *bg,
                return -EIO;
        }
 
+       /*
+        * When the last extent is removed, last_alloc can be smaller than the other write
+        * pointer. In that case, last_alloc should be moved to the corresponding write
+        * pointer position.
+        */
+       for (int i = 0; i < map->num_stripes; i++) {
+               if (zone_info[i].alloc_offset == WP_CONVENTIONAL)
+                       continue;
+               if (last_alloc <= zone_info[i].alloc_offset) {
+                       last_alloc = zone_info[i].alloc_offset;
+                       break;
+               }
+       }
+
        if (zone_info[0].alloc_offset == WP_CONVENTIONAL)
                zone_info[0].alloc_offset = last_alloc;