selftest: Remove unnecessary code for backup testenvs

setup_namespaces() already gets done for the backupfromdc's domain, so
this step is unnecessary for the restoredc and offlinebackupdc testenvs
(which are based off the backupfromdc's database).

The setup_namespaces() step is still necessary for the renamedc/labdc,
as these don't have the UPN/SPN suffixes for the new realm yet.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Nov  1 13:06:01 CET 2018 on sn-devel-144

diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index 89704c2686e4c66eec0c0d879cc8f81a316c89ef..41e550b51c03fee828beea38e321fe14b42cbc76 100755 (executable)
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -2843,11 +2843,6 @@ sub setup_restoredc
            return undef;
        }
 
-       my $upn_array = ["$env->{REALM}.upn"];
-       my $spn_array = ["$env->{REALM}.spn"];
-
-       $self->setup_namespaces($env, $upn_array, $spn_array);
-
        return $env;
 }
 
@@ -2939,11 +2934,6 @@ sub setup_offlinebackupdc
            return undef;
        }
 
-       my $upn_array = ["$env->{REALM}.upn"];
-       my $spn_array = ["$env->{REALM}.spn"];
-
-       $self->setup_namespaces($env, $upn_array, $spn_array);
-
        return $env;
 }