]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: ivtv: update *pos correctly in ivtv_read_pos()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 22 Feb 2019 06:36:41 +0000 (01:36 -0500)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 23 Sep 2019 20:11:32 +0000 (21:11 +0100)
commit f8e579f3ca0973daef263f513da5edff520a6c0d upstream.

We had intended to update *pos, but the current code is a no-op.

Fixes: 1a0adaf37c30 ("V4L/DVB (5345): ivtv driver for Conexant cx23416/cx23415 MPEG encoder/decoder")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/media/pci/ivtv/ivtv-fileops.c

index e5ff6277ca854704143398b43e585af5c6204dc5..d38cb158ddb36f2bea5f56a38909d517561acc36 100644 (file)
@@ -420,7 +420,7 @@ static ssize_t ivtv_read_pos(struct ivtv_stream *s, char __user *ubuf, size_t co
 
        IVTV_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc);
        if (rc > 0)
-               pos += rc;
+               *pos += rc;
        return rc;
 }