]> git.ipfire.org Git - thirdparty/httpx.git/commitdiff
Reorganize timeout config tests (#491)
authorFlorimond Manca <florimond.manca@gmail.com>
Tue, 22 Oct 2019 20:04:42 +0000 (22:04 +0200)
committerGitHub <noreply@github.com>
Tue, 22 Oct 2019 20:04:42 +0000 (22:04 +0200)
tests/test_config.py

index cd7c275d9afbeea2aad8aae1146e98f0d1c605dd..498116cf1d3c6e4860c98a54bccbee44d47a8fef 100644 (file)
@@ -158,17 +158,6 @@ def test_empty_http_version():
         httpx.HTTPVersionConfig([])
 
 
-def test_timeout_repr():
-    timeout = httpx.TimeoutConfig(timeout=5.0)
-    assert repr(timeout) == "TimeoutConfig(timeout=5.0)"
-
-    timeout = httpx.TimeoutConfig(read_timeout=5.0)
-    assert (
-        repr(timeout)
-        == "TimeoutConfig(connect_timeout=None, read_timeout=5.0, write_timeout=None)"
-    )
-
-
 def test_limits_repr():
     limits = httpx.PoolLimits(hard_limit=100)
     assert (
@@ -181,14 +170,31 @@ def test_ssl_eq():
     assert ssl == httpx.SSLConfig(verify=False)
 
 
+def test_limits_eq():
+    limits = httpx.PoolLimits(hard_limit=100)
+    assert limits == httpx.PoolLimits(hard_limit=100)
+
+
 def test_timeout_eq():
     timeout = httpx.TimeoutConfig(timeout=5.0)
     assert timeout == httpx.TimeoutConfig(timeout=5.0)
 
 
-def test_limits_eq():
-    limits = httpx.PoolLimits(hard_limit=100)
-    assert limits == httpx.PoolLimits(hard_limit=100)
+def test_timeout_from_nothing():
+    timeout = httpx.TimeoutConfig()
+    assert timeout.connect_timeout is None
+    assert timeout.read_timeout is None
+    assert timeout.write_timeout is None
+
+
+def test_timeout_from_none():
+    timeout = httpx.TimeoutConfig(timeout=None)
+    assert timeout == httpx.TimeoutConfig()
+
+
+def test_timeout_from_one_none_value():
+    timeout = httpx.TimeoutConfig(read_timeout=None)
+    assert timeout == httpx.TimeoutConfig()
 
 
 def test_timeout_from_tuple():
@@ -201,6 +207,17 @@ def test_timeout_from_config_instance():
     assert httpx.TimeoutConfig(timeout) == httpx.TimeoutConfig(timeout=5.0)
 
 
+def test_timeout_repr():
+    timeout = httpx.TimeoutConfig(timeout=5.0)
+    assert repr(timeout) == "TimeoutConfig(timeout=5.0)"
+
+    timeout = httpx.TimeoutConfig(read_timeout=5.0)
+    assert (
+        repr(timeout)
+        == "TimeoutConfig(connect_timeout=None, read_timeout=5.0, write_timeout=None)"
+    )
+
+
 @pytest.mark.skipif(
     not hasattr(ssl.SSLContext, "keylog_filename"),
     reason="requires OpenSSL 1.1.1 or higher",