]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
CLEANUP: tools: extra check in utoa_pad
authorAurelien DARRAGON <adarragon@haproxy.com>
Tue, 22 Nov 2022 10:42:07 +0000 (11:42 +0100)
committerChristopher Faulet <cfaulet@haproxy.com>
Tue, 22 Nov 2022 15:27:52 +0000 (16:27 +0100)
Removing useless check in utoa_pad().

This was reported by Ilya with the help of cppcheck.

src/tools.c

index b5b6442b3e24b7daf1ad08d5113d794e4ab09138..cfa1cc6aab678445d4315a32816fde3e1130e1c0 100644 (file)
@@ -421,8 +421,7 @@ char *utoa_pad(unsigned int n, char *dst, size_t size)
        }
        if (i + 2 > size) // (i + 1) + '\0'
                return NULL;  // too long
-       if (i < size)
-               i = size - 2; // padding - '\0'
+       i = size - 2; // padding - '\0'
 
        ret = dst + i + 1;
        *ret = '\0';