]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
firmware: qcom_scm: don't opencode kmemdup
authorMukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Tue, 10 Mar 2026 14:02:55 +0000 (19:32 +0530)
committerBjorn Andersson <andersson@kernel.org>
Mon, 23 Mar 2026 14:07:59 +0000 (09:07 -0500)
Lets not opencode kmemdup which is reported by coccinelle tool.
Fix it using kmemdup.

cocci warnings: (new ones prefixed by >>)
>> drivers/firmware/qcom/qcom_scm.c:916:11-18: WARNING opportunity for kmemdup

Fixes: 8b9d2050cfa0 ("firmware: qcom_scm: Add qcom_scm_pas_get_rsc_table() to get resource table")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601142144.HvSlBSI9-lkp@intel.com/
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260310140255.2520230-1-mukesh.ojha@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/firmware/qcom/qcom_scm.c

index 33333384ac81e3028a7a856fcc32ecadf40121d9..d1082695ec38e180cbb37fa6231018be6810da0a 100644 (file)
@@ -922,14 +922,13 @@ struct resource_table *qcom_scm_pas_get_rsc_table(struct qcom_scm_pas_context *c
                goto free_input_rt;
        }
 
-       tbl_ptr = kzalloc(size, GFP_KERNEL);
+       tbl_ptr = kmemdup(output_rt_tzm, size, GFP_KERNEL);
        if (!tbl_ptr) {
                qcom_tzmem_free(output_rt_tzm);
                ret = -ENOMEM;
                goto free_input_rt;
        }
 
-       memcpy(tbl_ptr, output_rt_tzm, size);
        *output_rt_size = size;
        qcom_tzmem_free(output_rt_tzm);