]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
repair: fix a valgrind reported error on i686
authorDave Chinner <dchinner@redhat.com>
Mon, 10 Oct 2011 01:08:32 +0000 (01:08 +0000)
committerAlex Elder <aelder@sgi.com>
Thu, 13 Oct 2011 10:01:12 +0000 (05:01 -0500)
Fix a potential prefetch read problem due to the first loop
execution of pf_batch_read potentially not initialising the fsbno
variable:

==10177== Thread 6:
==10177== Conditional jump or move depends on uninitialised value(s)
==10177==    at 0x8079CAB: pf_batch_read (prefetch.c:408)
==10177==    by 0x6A2996D: clone (clone.S:130)
==10177==

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
repair/prefetch.c

index d2fdf90aac6cbf4800a3f995a43d7c8872295987..da074a89cac085aa7e78df5d705163dbad082263 100644 (file)
@@ -397,7 +397,7 @@ pf_batch_read(
        int                     len, size;
        int                     i;
        int                     inode_bufs;
-       unsigned long           fsbno;
+       unsigned long           fsbno = 0;
        unsigned long           max_fsbno;
        char                    *pbuf;