]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: backup: Use VIR_ERR_CHECKPOINT_INCONSISTENT when starting a backup
authorPeter Krempa <pkrempa@redhat.com>
Tue, 3 Nov 2020 11:00:21 +0000 (12:00 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 9 Nov 2020 11:25:49 +0000 (12:25 +0100)
If we don't have a consistent chain of bitmaps for the backup to proceed
we'd report VIR_ERR_INVALID_ARG error code, which makes it hard to
decide whether an incremental backup makes even sense.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_backup.c

index eb0682e1930656bc409ab0e9460d379e9d066236..2e3a2b2e3c50517a28cbf6bbd3cae591a18d3d04 100644 (file)
@@ -206,7 +206,7 @@ qemuBackupDiskPrepareOneBitmaps(struct qemuBackupDiskData *dd,
     if (!qemuBlockBitmapChainIsValid(dd->domdisk->src,
                                      dd->backupdisk->incremental,
                                      blockNamedNodeData)) {
-        virReportError(VIR_ERR_INVALID_ARG,
+        virReportError(VIR_ERR_CHECKPOINT_INCONSISTENT,
                        _("missing or broken bitmap '%s' for disk '%s'"),
                        dd->backupdisk->incremental, dd->domdisk->dst);
         return -1;