]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i2c: spacemit: drop IRQF_ONESHOT flag from IRQ request
authorYixun Lan <dlan@kernel.org>
Wed, 21 Jan 2026 23:52:00 +0000 (07:52 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Thu, 22 Jan 2026 13:07:58 +0000 (14:07 +0100)
In commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT without a
threaded handler")[1], it will check IRQF_ONESHOT flag in IRQ request,
and gives a warning if there is no threaded handler. Drop this flag to
fix this warning.

Link: https://lore.kernel.org/r/20260112134013.eQWyReHR@linutronix.de/
Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC")
Signed-off-by: Yixun Lan <dlan@kernel.org>
Cc: <stable@vger.kernel.org> # v6.15+
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20260122-05-k1-i2c-irq-v1-1-9b8d94bbcd22@kernel.org
drivers/i2c/busses/i2c-k1.c

index d42c03ef5db5984ea8e06b3d7eb485b4f899e616..8ef6d5d1927b728af6056768dfa69e1f849d0f9e 100644 (file)
@@ -566,7 +566,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev)
                return dev_err_probe(dev, i2c->irq, "failed to get irq resource");
 
        ret = devm_request_irq(i2c->dev, i2c->irq, spacemit_i2c_irq_handler,
-                              IRQF_NO_SUSPEND | IRQF_ONESHOT, dev_name(i2c->dev), i2c);
+                              IRQF_NO_SUSPEND, dev_name(i2c->dev), i2c);
        if (ret)
                return dev_err_probe(dev, ret, "failed to request irq");