drm/amd/pm: Use feature bits data structure

Feature bits are not necessarily restricted to 64-bits. Use
smu_feature_bits data structure to represent feature mask for checking
DPM status.

Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Asad Kamal <asad.kamal@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
index 7c63c631f6d42953279b899cdb25b5e111d06e43..c58290686f0d01de0661a83f1582bef4a79d017d 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
+++ b/drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h
@@ -477,6 +477,23 @@ struct smu_feature_bits {
        DECLARE_BITMAP(bits, SMU_FEATURE_MAX);
 };
 
+/*
+ * Helpers for initializing smu_feature_bits statically.
+ * Use SMU_FEATURE_BIT_INIT() which automatically handles array indexing:
+ *   static const struct smu_feature_bits example = {
+ *       .bits = {
+ *           SMU_FEATURE_BIT_INIT(5),
+ *           SMU_FEATURE_BIT_INIT(10),
+ *           SMU_FEATURE_BIT_INIT(65),
+ *           SMU_FEATURE_BIT_INIT(100)
+ *       }
+ *   };
+ */
+#define SMU_FEATURE_BITS_ELEM(bit) ((bit) / BITS_PER_LONG)
+#define SMU_FEATURE_BITS_POS(bit) ((bit) % BITS_PER_LONG)
+#define SMU_FEATURE_BIT_INIT(bit) \
+       [SMU_FEATURE_BITS_ELEM(bit)] = (1UL << SMU_FEATURE_BITS_POS(bit))
+
 enum smu_feature_list {
        SMU_FEATURE_LIST_SUPPORTED,
        SMU_FEATURE_LIST_ALLOWED,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
index b22a0e91826dcb79101590008a658f44038c2d28..814f24b7ccc4cb8547f3b8886788345e3820a612 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
@@ -65,14 +65,15 @@
 #define SMU_FEATURES_HIGH_MASK       0xFFFFFFFF00000000
 #define SMU_FEATURES_HIGH_SHIFT      32
 
-#define SMC_DPM_FEATURE ( \
-       FEATURE_DPM_PREFETCHER_MASK | \
-       FEATURE_DPM_GFXCLK_MASK | \
-       FEATURE_DPM_UCLK_MASK | \
-       FEATURE_DPM_SOCCLK_MASK | \
-       FEATURE_DPM_MP0CLK_MASK | \
-       FEATURE_DPM_FCLK_MASK | \
-       FEATURE_DPM_XGMI_MASK)
+static const struct smu_feature_bits arcturus_dpm_features = {
+       .bits = { SMU_FEATURE_BIT_INIT(FEATURE_DPM_PREFETCHER_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_GFXCLK_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_UCLK_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_SOCCLK_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_MP0CLK_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_FCLK_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_XGMI_BIT) }
+};
 
 #define smnPCIE_ESM_CTRL                       0x111003D0
 
@@ -1527,12 +1528,14 @@ static bool arcturus_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&arcturus_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int arcturus_dpm_set_vcn_enable(struct smu_context *smu,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c
index 4a5dcc893665882405173e16551c688df722a4f1..406acfbbbc63a9d9094b46e397fc79cf94d234ef 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c
@@ -60,11 +60,13 @@ static struct gfx_user_settings {
 
 static uint32_t cyan_skillfish_sclk_default;
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_FCLK_DPM_BIT)      |       \
-       FEATURE_MASK(FEATURE_SOC_DPM_BIT)       |       \
-       FEATURE_MASK(FEATURE_GFX_DPM_BIT))
+static const struct smu_feature_bits cyan_skillfish_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_FCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SOC_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_GFX_DPM_BIT)
+       }
+};
 
 static struct cmn2asic_msg_mapping cyan_skillfish_message_map[SMU_MSG_MAX_COUNT] = {
        MSG_MAP(TestMessage,                    PPSMC_MSG_TestMessage,                  0),
@@ -362,6 +364,7 @@ static bool cyan_skillfish_is_dpm_running(struct smu_context *smu)
        struct amdgpu_device *adev = smu->adev;
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        /* we need to re-init after suspend so return false */
        if (adev->in_suspend)
@@ -378,7 +381,8 @@ static bool cyan_skillfish_is_dpm_running(struct smu_context *smu)
                cyan_skillfish_get_smu_metrics_data(smu, METRICS_CURR_GFXCLK,
                        &cyan_skillfish_sclk_default);
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&cyan_skillfish_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static ssize_t cyan_skillfish_get_gpu_metrics(struct smu_context *smu,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
index f14eed05252652f4dfb11cd01c76e4b9fc5ed70c..f5be643951084f99852d6cbe44098f77ba205d61 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
@@ -58,16 +58,18 @@
 #undef pr_info
 #undef pr_debug
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_DPM_PREFETCHER_BIT) | \
-       FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_GFX_PACE_BIT)   | \
-       FEATURE_MASK(FEATURE_DPM_UCLK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_MP0CLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_LINK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_DCEFCLK_BIT))
+static const struct smu_feature_bits navi10_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_PREFETCHER_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_GFXCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_GFX_PACE_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_UCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_SOCCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_MP0CLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_LINK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_DCEFCLK_BIT)
+       }
+};
 
 #define SMU_11_0_GFX_BUSY_THRESHOLD 15
 
@@ -1620,12 +1622,14 @@ static bool navi10_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&navi10_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int navi10_get_fan_speed_rpm(struct smu_context *smu,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
index 98a02fc082143bcdc189e7f8b8bf38552ca267f7..7d23b6c8c5388768a5994ff9bf34d0cfd3f2faf7 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
@@ -60,16 +60,18 @@
 #undef pr_info
 #undef pr_debug
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_DPM_PREFETCHER_BIT) | \
-       FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_UCLK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_LINK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_FCLK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_DCEFCLK_BIT)    | \
-       FEATURE_MASK(FEATURE_DPM_MP0CLK_BIT))
+static const struct smu_feature_bits sienna_cichlid_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_PREFETCHER_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_GFXCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_UCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_LINK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_SOCCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_FCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_DCEFCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_MP0CLK_BIT)
+       }
+};
 
 #define SMU_11_0_7_GFX_BUSY_THRESHOLD 15
 
@@ -1535,12 +1537,14 @@ static bool sienna_cichlid_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&sienna_cichlid_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int sienna_cichlid_get_fan_speed_rpm(struct smu_context *smu,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 4de1778ea6b3114e37980ec0e56d8be88275d0f5..f8b76577d008722cc8bb020a66080a7c82582f16 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -58,17 +58,19 @@
 #define SMUIO_GFX_MISC_CNTL__SMU_GFX_cold_vs_gfxoff_MASK       0x00000001L
 #define SMUIO_GFX_MISC_CNTL__PWR_GFXOFF_STATUS_MASK            0x00000006L
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_CCLK_DPM_BIT) | \
-       FEATURE_MASK(FEATURE_VCN_DPM_BIT)        | \
-       FEATURE_MASK(FEATURE_FCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SOCCLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_MP0CLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_LCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SHUBCLK_DPM_BIT)    | \
-       FEATURE_MASK(FEATURE_DCFCLK_DPM_BIT)| \
-       FEATURE_MASK(FEATURE_GFX_DPM_BIT))
+static const struct smu_feature_bits vangogh_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_CCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_VCN_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_FCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SOCCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_MP0CLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_LCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SHUBCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DCFCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_GFX_DPM_BIT)
+       }
+};
 
 static struct cmn2asic_msg_mapping vangogh_message_map[SMU_MSG_MAX_COUNT] = {
        MSG_MAP(TestMessage,                    PPSMC_MSG_TestMessage,                  0),
@@ -505,6 +507,7 @@ static bool vangogh_is_dpm_running(struct smu_context *smu)
        struct amdgpu_device *adev = smu->adev;
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        /* we need to re-init after suspend so return false */
        if (adev->in_suspend)
@@ -515,7 +518,8 @@ static bool vangogh_is_dpm_running(struct smu_context *smu)
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&vangogh_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int vangogh_get_dpm_clk_limited(struct smu_context *smu, enum smu_clk_type clk_type,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
index 3b6a34644a920088d1694c2078e53a134a19ecb0..4185c7282a11f126fe8622039f0d7e57d5029d89 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
@@ -61,15 +61,18 @@
        [smu_feature] = {1, (aldebaran_feature)}
 
 #define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-                         FEATURE_MASK(FEATURE_DATA_CALCULATIONS) | \
-                         FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT)  | \
-                         FEATURE_MASK(FEATURE_DPM_UCLK_BIT)    | \
-                         FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT)  | \
-                         FEATURE_MASK(FEATURE_DPM_FCLK_BIT)    | \
-                         FEATURE_MASK(FEATURE_DPM_LCLK_BIT)    | \
-                         FEATURE_MASK(FEATURE_DPM_XGMI_BIT)    | \
-                         FEATURE_MASK(FEATURE_DPM_VCN_BIT))
+static const struct smu_feature_bits aldebaran_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_DATA_CALCULATIONS),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_GFXCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_UCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_SOCCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_FCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_LCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_XGMI_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_VCN_BIT)
+       }
+};
 
 #define smnPCIE_ESM_CTRL                       0x111003D0
 
@@ -1396,11 +1399,13 @@ static bool aldebaran_is_dpm_running(struct smu_context *smu)
 {
        int ret;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
        if (ret)
                return false;
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&aldebaran_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int aldebaran_i2c_xfer(struct i2c_adapter *i2c_adap,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
index 9c4298736b28939854d0f34ef9a6975a5149dcd1..0856c1c34d7a24652f309f1e4484b10fa825e498 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
@@ -59,14 +59,16 @@
 
 #define to_amdgpu_device(x) (container_of(x, struct amdgpu_device, pm.smu_i2c))
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_UCLK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_LINK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_FCLK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_MP0CLK_BIT))
+static const struct smu_feature_bits smu_v13_0_0_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_GFXCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_UCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_LINK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_SOCCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_FCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_MP0CLK_BIT)
+       }
+};
 
 #define MP0_MP1_DATA_REGION_SIZE_COMBOPPTABLE  0x4000
 
@@ -690,12 +692,14 @@ static bool smu_v13_0_0_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&smu_v13_0_0_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int smu_v13_0_0_system_features_control(struct smu_context *smu,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c
index 41c61362f7fc20b1634fbf6fadf8cce8636480a2..741762f4bd2cf42b3bbff013d5c6ae1070f9082d 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_4_ppt.c
@@ -52,24 +52,25 @@
 #define mmMP1_SMN_C2PMSG_90                    0x029a
 #define mmMP1_SMN_C2PMSG_90_BASE_IDX           1
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-
 #define SMU_13_0_4_UMD_PSTATE_GFXCLK                   938
 #define SMU_13_0_4_UMD_PSTATE_SOCCLK                   938
 #define SMU_13_0_4_UMD_PSTATE_FCLK                     1875
 
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_CCLK_DPM_BIT) | \
-       FEATURE_MASK(FEATURE_VCN_DPM_BIT)        | \
-       FEATURE_MASK(FEATURE_FCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SOCCLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_MP0CLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_LCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SHUBCLK_DPM_BIT)    | \
-       FEATURE_MASK(FEATURE_DCFCLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_ISP_DPM_BIT)        | \
-       FEATURE_MASK(FEATURE_IPU_DPM_BIT)        | \
-       FEATURE_MASK(FEATURE_GFX_DPM_BIT))
+static const struct smu_feature_bits smu_v13_0_4_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_CCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_VCN_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_FCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SOCCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_MP0CLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_LCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SHUBCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DCFCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_ISP_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_IPU_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_GFX_DPM_BIT)
+       }
+};
 
 static struct cmn2asic_msg_mapping smu_v13_0_4_message_map[SMU_MSG_MAX_COUNT] = {
        MSG_MAP(TestMessage,                    PPSMC_MSG_TestMessage,                  1),
@@ -213,13 +214,15 @@ static bool smu_v13_0_4_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
 
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&smu_v13_0_4_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int smu_v13_0_4_system_features_control(struct smu_context *smu, bool en)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
index e4be727789c00e5355aea9c341a8a4c279c06bea..7311162e50f005e629f6250cfa26d48ddc9c9269 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_5_ppt.c
@@ -51,17 +51,19 @@
 #define mmMP1_C2PMSG_33                                                                                (0xbee261 + 0xb00000 / 4)
 #define mmMP1_C2PMSG_33_BASE_IDX                                                                   0
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_CCLK_DPM_BIT) | \
-       FEATURE_MASK(FEATURE_FCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_LCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_GFX_DPM_BIT)        | \
-       FEATURE_MASK(FEATURE_VCN_DPM_BIT)        | \
-       FEATURE_MASK(FEATURE_DCFCLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_SOCCLK_DPM_BIT)| \
-       FEATURE_MASK(FEATURE_MP0CLK_DPM_BIT)| \
-       FEATURE_MASK(FEATURE_SHUBCLK_DPM_BIT))
+static const struct smu_feature_bits smu_v13_0_5_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_CCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_FCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_LCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_GFX_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_VCN_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DCFCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SOCCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_MP0CLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SHUBCLK_DPM_BIT)
+       }
+};
 
 static struct cmn2asic_msg_mapping smu_v13_0_5_message_map[SMU_MSG_MAX_COUNT] = {
        MSG_MAP(TestMessage,                    PPSMC_MSG_TestMessage,                  1),
@@ -231,13 +233,15 @@ static bool smu_v13_0_5_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
 
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&smu_v13_0_5_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int smu_v13_0_5_mode_reset(struct smu_context *smu, int type)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index bd893e95515f84134fd14e557a6892bbea1c1251..97866e5701921a7af805f14471eceaf6a416ecb2 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -76,12 +76,18 @@ MODULE_FIRMWARE("amdgpu/smu_13_0_14.bin");
        [smu_feature] = { 1, (smu_13_0_6_feature) }
 
 #define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE                                                        \
-       (FEATURE_MASK(FEATURE_DATA_CALCULATION) |                              \
-        FEATURE_MASK(FEATURE_DPM_GFXCLK) | FEATURE_MASK(FEATURE_DPM_UCLK) |   \
-        FEATURE_MASK(FEATURE_DPM_SOCCLK) | FEATURE_MASK(FEATURE_DPM_FCLK) |   \
-        FEATURE_MASK(FEATURE_DPM_LCLK) | FEATURE_MASK(FEATURE_DPM_XGMI) |     \
-        FEATURE_MASK(FEATURE_DPM_VCN))
+static const struct smu_feature_bits smu_v13_0_6_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_DATA_CALCULATION),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_GFXCLK),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_UCLK),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_SOCCLK),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_FCLK),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_LCLK),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_XGMI),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_VCN)
+       }
+};
 
 #define smnPCIE_ESM_CTRL 0x93D0
 #define smnPCIE_LC_LINK_WIDTH_CNTL 0x1a340288
@@ -2284,6 +2290,7 @@ static bool smu_v13_0_6_is_dpm_running(struct smu_context *smu)
 {
        int ret;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        if (amdgpu_ip_version(smu->adev, MP1_HWIP, 0) == IP_VERSION(13, 0, 12))
                return smu_v13_0_12_is_dpm_running(smu);
@@ -2293,7 +2300,8 @@ static bool smu_v13_0_6_is_dpm_running(struct smu_context *smu)
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&smu_v13_0_6_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int smu_v13_0_6_request_i2c_xfer(struct smu_context *smu,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
index 415766dbfe6cffaddbc9dbd9b40e6ecfa209c9d6..eeff6c874635d711443dedefe9a3ff0967dd1577 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c
@@ -59,14 +59,16 @@
 
 #define to_amdgpu_device(x) (container_of(x, struct amdgpu_device, pm.smu_i2c))
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_UCLK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_LINK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_FCLK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_MP0CLK_BIT))
+static const struct smu_feature_bits smu_v13_0_7_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_GFXCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_UCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_LINK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_SOCCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_FCLK_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DPM_MP0CLK_BIT)
+       }
+};
 
 #define smnMP1_FIRMWARE_FLAGS_SMU_13_0_7   0x3b10028
 
@@ -698,12 +700,14 @@ static bool smu_v13_0_7_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&smu_v13_0_7_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static uint32_t smu_v13_0_7_get_throttler_status(SmuMetrics_t *metrics)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
index 7f70f79c3b2f7c7bf2eea29198cb547622bf01b7..2331dbb9181ab9d3b421e673b8372fca9fe4bb52 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
@@ -55,17 +55,19 @@
 #define SMU_13_0_1_UMD_PSTATE_SOCCLK                         678
 #define SMU_13_0_1_UMD_PSTATE_FCLK                               1800
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_CCLK_DPM_BIT) | \
-       FEATURE_MASK(FEATURE_VCN_DPM_BIT)        | \
-       FEATURE_MASK(FEATURE_FCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SOCCLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_MP0CLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_LCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SHUBCLK_DPM_BIT)    | \
-       FEATURE_MASK(FEATURE_DCFCLK_DPM_BIT)| \
-       FEATURE_MASK(FEATURE_GFX_DPM_BIT))
+static const struct smu_feature_bits yellow_carp_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_CCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_VCN_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_FCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SOCCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_MP0CLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_LCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SHUBCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DCFCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_GFX_DPM_BIT)
+       }
+};
 
 static struct cmn2asic_msg_mapping yellow_carp_message_map[SMU_MSG_MAX_COUNT] = {
        MSG_MAP(TestMessage,                    PPSMC_MSG_TestMessage,                  1),
@@ -258,13 +260,15 @@ static bool yellow_carp_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
 
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&yellow_carp_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int yellow_carp_post_smu_init(struct smu_context *smu)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c
index a4e376e8328ce897c5a29eb87365e0b4c933af14..019e43fdecd63ebbdd2d2acb11c0a149ee4a5127 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c
@@ -72,19 +72,21 @@
 #define SMU_14_0_4_UMD_PSTATE_GFXCLK                   938
 #define SMU_14_0_4_UMD_PSTATE_SOCCLK                   938
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_CCLK_DPM_BIT) | \
-       FEATURE_MASK(FEATURE_VCN_DPM_BIT)        | \
-       FEATURE_MASK(FEATURE_FCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SOCCLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_LCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SHUBCLK_DPM_BIT)    | \
-       FEATURE_MASK(FEATURE_DCFCLK_DPM_BIT)| \
-       FEATURE_MASK(FEATURE_ISP_DPM_BIT)| \
-       FEATURE_MASK(FEATURE_IPU_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_GFX_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_VPE_DPM_BIT))
+static const struct smu_feature_bits smu_v14_0_0_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_CCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_VCN_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_FCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SOCCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_LCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SHUBCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DCFCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_ISP_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_IPU_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_GFX_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_VPE_DPM_BIT)
+       }
+};
 
 enum smu_mall_pg_config {
        SMU_MALL_PG_CONFIG_PMFW_CONTROL = 0,
@@ -471,13 +473,15 @@ static bool smu_v14_0_0_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
 
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&smu_v14_0_0_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int smu_v14_0_0_set_watermarks_table(struct smu_context *smu,

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c
index 3c351ee41e6842b0d2c0d2cc20d68d539a1fe435..eb8bad2de1cc274572bd95b21d3e489c0dbcee34 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c
@@ -56,13 +56,13 @@
 
 #define to_amdgpu_device(x) (container_of(x, struct amdgpu_device, pm.smu_i2c))
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_DPM_GFXCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_UCLK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_LINK_BIT)       | \
-       FEATURE_MASK(FEATURE_DPM_SOCCLK_BIT)     | \
-       FEATURE_MASK(FEATURE_DPM_FCLK_BIT))
+static const struct smu_feature_bits smu_v14_0_2_dpm_features = {
+       .bits = { SMU_FEATURE_BIT_INIT(FEATURE_DPM_GFXCLK_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_UCLK_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_LINK_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_SOCCLK_BIT),
+                 SMU_FEATURE_BIT_INIT(FEATURE_DPM_FCLK_BIT) }
+};
 
 #define MP0_MP1_DATA_REGION_SIZE_COMBOPPTABLE  0x4000
 #define DEBUGSMC_MSG_Mode1Reset        2
@@ -590,12 +590,14 @@ static bool smu_v14_0_2_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&smu_v14_0_2_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static uint32_t smu_v14_0_2_get_throttler_status(SmuMetrics_t *metrics)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_0_ppt.c
index b48444706c1e35a1dd7596b5c67ddffb156767e5..d66e9a1a0ef8311da75b5dbd1c899ca7258d78b6 100644 (file)
--- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_0_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_0_ppt.c
@@ -70,19 +70,21 @@
 #define SMU_15_0_UMD_PSTATE_FCLK 1800
 
 
-#define FEATURE_MASK(feature) (1ULL << feature)
-#define SMC_DPM_FEATURE ( \
-       FEATURE_MASK(FEATURE_CCLK_DPM_BIT) | \
-       FEATURE_MASK(FEATURE_VCN_DPM_BIT)        | \
-       FEATURE_MASK(FEATURE_FCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SOCCLK_DPM_BIT)     | \
-       FEATURE_MASK(FEATURE_LCLK_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_SHUBCLK_DPM_BIT)    | \
-       FEATURE_MASK(FEATURE_DCFCLK_DPM_BIT)| \
-       FEATURE_MASK(FEATURE_ISP_DPM_BIT)| \
-       FEATURE_MASK(FEATURE_NPU_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_GFX_DPM_BIT)       | \
-       FEATURE_MASK(FEATURE_VPE_DPM_BIT))
+static const struct smu_feature_bits smu_v15_0_0_dpm_features = {
+       .bits = {
+               SMU_FEATURE_BIT_INIT(FEATURE_CCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_VCN_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_FCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SOCCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_LCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_SHUBCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_DCFCLK_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_ISP_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_NPU_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_GFX_DPM_BIT),
+               SMU_FEATURE_BIT_INIT(FEATURE_VPE_DPM_BIT)
+       }
+};
 
 enum smu_mall_pg_config {
        SMU_MALL_PG_CONFIG_PMFW_CONTROL = 0,
@@ -445,13 +447,15 @@ static bool smu_v15_0_0_is_dpm_running(struct smu_context *smu)
 {
        int ret = 0;
        uint64_t feature_enabled;
+       uint32_t feature_mask[2];
 
        ret = smu_cmn_get_enabled_mask(smu, &feature_enabled);
 
        if (ret)
                return false;
 
-       return !!(feature_enabled & SMC_DPM_FEATURE);
+       smu_feature_bits_to_arr32(&smu_v15_0_0_dpm_features, feature_mask, 64);
+       return !!(feature_enabled & *(uint64_t *)feature_mask);
 }
 
 static int smu_v15_0_0_set_watermarks_table(struct smu_context *smu,