]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Delint dnsdist-dnscrypt.cc
authorRemi Gacogne <remi.gacogne@powerdns.com>
Mon, 4 Mar 2024 11:26:39 +0000 (12:26 +0100)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 6 Mar 2024 10:57:35 +0000 (11:57 +0100)
pdns/dnsdistdist/dnsdist-dnscrypt.cc
pdns/dnsdistdist/dnsdist.hh

index 8f02910aaa8a8ff5f15626ff2a65f939803bf577..a7a776cba7fea0209d143c7a5fa5779bc3de01d7 100644 (file)
 #include "dnscrypt.hh"
 
 #ifdef HAVE_DNSCRYPT
-int handleDNSCryptQuery(PacketBuffer& packet, DNSCryptQuery& query, bool tcp, time_t now, PacketBuffer& response)
+bool handleDNSCryptQuery(PacketBuffer& packet, DNSCryptQuery& query, bool tcp, time_t now, PacketBuffer& response)
 {
   query.parsePacket(packet, tcp, now);
 
-  if (query.isValid() == false) {
+  if (!query.isValid()) {
     vinfolog("Dropping DNSCrypt invalid query");
     return false;
   }
 
-  if (query.isEncrypted() == false) {
+  if (!query.isEncrypted()) {
     query.getCertificateResponse(now, response);
 
     return false;
index 9db31de62fd8a63fc491ced7033f3454cbcb79dd..e345614be5d7f0014cc82f4f15b1c05c54ee29b4 100644 (file)
@@ -1241,7 +1241,7 @@ bool responseContentMatches(const PacketBuffer& response, const DNSName& qname,
 bool checkQueryHeaders(const struct dnsheader& dnsHeader, ClientState& clientState);
 
 extern std::vector<std::shared_ptr<DNSCryptContext>> g_dnsCryptLocals;
-int handleDNSCryptQuery(PacketBuffer& packet, DNSCryptQuery& query, bool tcp, time_t now, PacketBuffer& response);
+bool handleDNSCryptQuery(PacketBuffer& packet, DNSCryptQuery& query, bool tcp, time_t now, PacketBuffer& response);
 bool checkDNSCryptQuery(const ClientState& cs, PacketBuffer& query, std::unique_ptr<DNSCryptQuery>& dnsCryptQuery, time_t now, bool tcp);
 
 #include "dnsdist-snmp.hh"