]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: ACL implicit arguments must be created with unresolved flag
authorWilly Tarreau <w@1wt.eu>
Fri, 15 Jun 2012 06:02:34 +0000 (08:02 +0200)
committerWilly Tarreau <w@1wt.eu>
Fri, 15 Jun 2012 06:02:34 +0000 (08:02 +0200)
Commit 496aa0 fixed a design issue by adding an "unresolved" flag to the
ACL arguments. Unfortunately this unresolved flag was not set when building
the fake argument some ACL need when using an implicit argument pointing to
the local proxy.

Special thanks to Michael Kearey who reported the issue with a reproducer
and the commit introducing the bug.

src/acl.c

index e51dafc9de999624bec372ca4c42e37208cf9b0f..e2e72ceb6a1c75e33e3c4cf6469f0947d1a66995 100644 (file)
--- a/src/acl.c
+++ b/src/acl.c
@@ -1422,6 +1422,7 @@ struct acl_expr *parse_acl_expr(const char **args, char **err)
                         */
                        expr->args = calloc(2, sizeof(*expr->args));
                        expr->args[0].type = type;
+                       expr->args[0].unresolved = 1;
                        expr->args[0].data.str.str = strdup("");
                        expr->args[0].data.str.len = 1;
                        expr->args[0].data.str.len = 0;