]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
xtensa: Optimize bitwise splicing operation
authorTakayuki 'January June' Suwa <jjsuwa_sys3175@yahoo.co.jp>
Sun, 8 Jan 2023 05:03:49 +0000 (14:03 +0900)
committerMax Filippov <jcmvbkbc@gmail.com>
Sun, 8 Jan 2023 22:14:39 +0000 (14:14 -0800)
This patch optimizes the operation of cutting and splicing two register
values at a specified bit position, in other words, combining (bitwise
ORing) bits 0 through (C-1) of the register with bits C through 31
of the other, where C is the specified immediate integer 17 through 31.

This typically applies to signed copy of floating point number and
__builtin_return_address() if the windowed register ABI, and saves one
instruction compared to four shifts and a bitwise OR by the default RTL
combination pass.

gcc/ChangeLog:

* config/xtensa/xtensa.md (*splice_bits):
New insn_and_split pattern.

gcc/config/xtensa/xtensa.md

index 0a26d3dccf44c356c26839d7e2c6845939a1f9f8..db1d68ee6584cce10ff0efdeddec0072ff409e7d 100644 (file)
    (set_attr "mode"    "SI")
    (set_attr "length"  "3")])
 
+(define_insn_and_split "*splice_bits"
+  [(set (match_operand:SI 0 "register_operand" "=a")
+       (ior:SI (and:SI (match_operand:SI 1 "register_operand" "r")
+                       (match_operand:SI 3 "const_int_operand" "i"))
+               (and:SI (match_operand:SI 2 "register_operand" "r")
+                       (match_operand:SI 4 "const_int_operand" "i"))))]
+
+  "!optimize_debug && optimize
+   && INTVAL (operands[3]) + INTVAL (operands[4]) == -1
+   && (exact_log2 (INTVAL (operands[3]) + 1) > 16
+       || exact_log2 (INTVAL (operands[4]) + 1) > 16)"
+  "#"
+  "&& can_create_pseudo_p ()"
+  [(set (match_dup 5)
+       (ashift:SI (match_dup 1)
+                  (match_dup 4)))
+   (set (match_dup 6)
+       (lshiftrt:SI (match_dup 2)
+                    (match_dup 3)))
+   (set (match_dup 0)
+       (ior:SI (lshiftrt:SI (match_dup 5)
+                            (match_dup 4))
+               (ashift:SI (match_dup 6)
+                          (match_dup 3))))]
+{
+  int shift;
+  if (INTVAL (operands[3]) < 0)
+    {
+      rtx x;
+      x = operands[1], operands[1] = operands[2], operands[2] = x;
+      x = operands[3], operands[3] = operands[4], operands[4] = x;
+    }
+  shift = floor_log2 (INTVAL (operands[3]) + 1);
+  operands[3] = GEN_INT (shift);
+  operands[4] = GEN_INT (32 - shift);
+  operands[5] = gen_reg_rtx (SImode);
+  operands[6] = gen_reg_rtx (SImode);
+}
+  [(set_attr "type"    "arith")
+   (set_attr "mode"    "SI")
+   (set (attr "length")
+       (if_then_else (match_test "TARGET_DENSITY
+                                  && (INTVAL (operands[3]) == 0x7FFFFFFF
+                                      || INTVAL (operands[4]) == 0x7FFFFFFF)")
+                     (const_int 11)
+                     (const_int 12)))])
+
 \f
 ;; Zero-extend instructions.