]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: hisilicon: clkdivider-hi6220: convert from divider_round_rate() to divider_deter...
authorBrian Masney <bmasney@redhat.com>
Thu, 8 Jan 2026 21:16:26 +0000 (16:16 -0500)
committerBrian Masney <bmasney@redhat.com>
Thu, 22 Jan 2026 15:48:25 +0000 (10:48 -0500)
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: 619a6210f398 ("clk: hisilicon: clkdivider-hi6220: convert from round_rate() to determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
drivers/clk/hisilicon/clkdivider-hi6220.c

index 6bae18a84cb6c0e19dd00762613fd9051849fdd0..fd7ceb92d6515757f79cd0496ce4a8ae7220f321 100644 (file)
@@ -60,10 +60,8 @@ static int hi6220_clkdiv_determine_rate(struct clk_hw *hw,
 {
        struct hi6220_clk_divider *dclk = to_hi6220_clk_divider(hw);
 
-       req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate, dclk->table,
-                                      dclk->width, CLK_DIVIDER_ROUND_CLOSEST);
-
-       return 0;
+       return divider_determine_rate(hw, req, dclk->table, dclk->width,
+                                     CLK_DIVIDER_ROUND_CLOSEST);
 }
 
 static int hi6220_clkdiv_set_rate(struct clk_hw *hw, unsigned long rate,