]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t4002: fix "diff can read from stdin" syntax
authorD. Ben Knoble <ben.knoble+github@gmail.com>
Fri, 14 Jul 2023 13:30:10 +0000 (13:30 +0000)
committerJunio C Hamano <gitster@pobox.com>
Fri, 14 Jul 2023 16:53:06 +0000 (09:53 -0700)
I noticed this test was producing output like

```
t4002-diff-basic.sh: test_expect_successdiff can read from stdin: not found
```

which is rather odd. Investigation shows an error of shell syntax:
foo'abc' is the same as fooabc to the shell. Perhaps obviously, this is
not a valid command for the test.

I am surprised this doesn't count as an error in the test, but that
accounts for it going unnoticed.

Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t4002-diff-basic.sh

index d524d4057dc82dd04124c4297600265444ecbdfd..7afc883ec374e1c4b747ed80ba64575d05017502 100755 (executable)
@@ -403,7 +403,7 @@ test_expect_success 'diff-tree -r B A == diff-tree -r -R A B' '
        git diff-tree -r -R $tree_A $tree_B >.test-b &&
        cmp -s .test-a .test-b'
 
-test_expect_success'diff can read from stdin' '
+test_expect_success 'diff can read from stdin' '
        test_must_fail git diff --no-index -- MN - < NN |
                grep -v "^index" | sed "s#/-#/NN#" >.test-a &&
        test_must_fail git diff --no-index -- MN NN |