Use Kahan's formula in cacosh

diff --git a/ChangeLog b/ChangeLog
index 1ccc3ddab06049f09e3a5b9e26c069e398252851..4d2b1fcc984c5303f998eec86e0d0212ce2afdca 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-12-21  Ulrich Drepper  <drepper@gmail.com>
+
+       * math/s_cacosh.c: Use Kahan's formula if the subtraction could lead
+       to large cancellation.
+       * math/s_cacoshf.c: Likewise.
+       * math/s_cacoshl.c: Likewise.
+
 2011-11-18  Richard B. Kreckel  <kreckel@ginac.de>
 
        [BZ #13305]

diff --git a/math/s_cacosh.c b/math/s_cacosh.c
index df5ce6945d48522e5c2e86afccb03488743274b8..cb01ca87c545352131efe3389b795906890c4535 100644 (file)
--- a/math/s_cacosh.c
+++ b/math/s_cacosh.c
@@ -65,6 +65,11 @@ __cacosh (__complex__ double x)
       __real__ res = 0.0;
       __imag__ res = __copysign (M_PI_2, __imag__ x);
     }
+  /* The factor 16 is just a guess.  */
+  else if (16.0 * fabs (__imag__ x) < fabs (__real__ x))
+    /* Kahan's formula which avoid cancellation through subtraction in
+       some cases.  */
+    res = 2.0 * __clog (__csqrt ((x + 1.0) / 2.0) + __csqrt ((x - 1.0) / 2.0));
   else
     {
       __complex__ double y;

diff --git a/math/s_cacoshf.c b/math/s_cacoshf.c
index aa4696f10b28ad112e49380d45fe12d49a0fcedf..fe046929e819752ff454507f9ecc1d60526e973f 100644 (file)
--- a/math/s_cacoshf.c
+++ b/math/s_cacoshf.c
@@ -65,6 +65,12 @@ __cacoshf (__complex__ float x)
       __real__ res = 0.0;
       __imag__ res = __copysignf (M_PI_2, __imag__ x);
     }
+  /* The factor 16 is just a guess.  */
+  else if (16.0 * fabsf (__imag__ x) < fabsf (__real__ x))
+    /* Kahan's formula which avoid cancellation through subtraction in
+       some cases.  */
+    res = 2.0 * __clogf (__csqrtf ((x + 1.0) / 2.0)
+                        + __csqrtf ((x - 1.0) / 2.0));
   else
     {
       __complex__ float y;

diff --git a/math/s_cacoshl.c b/math/s_cacoshl.c
index b90b196959f8c479b81d810101f334e0001c8ef7..84c2715d220b11b4c200b860464a481f06349c5a 100644 (file)
--- a/math/s_cacoshl.c
+++ b/math/s_cacoshl.c
@@ -65,6 +65,12 @@ __cacoshl (__complex__ long double x)
       __real__ res = 0.0;
       __imag__ res = __copysignl (M_PI_2l, __imag__ x);
     }
+  /* The factor 16 is just a guess.  */
+  else if (16.0L * fabsl (__imag__ x) < fabsl (__real__ x))
+    /* Kahan's formula which avoid cancellation through subtraction in
+       some cases.  */
+    res = 2.0L * __clogl (__csqrtl ((x + 1.0L) / 2.0L)
+                         + __csqrtl ((x - 1.0L) / 2.0L));
   else
     {
       __complex__ long double y;