]> git.ipfire.org Git - thirdparty/grub.git/commitdiff
commands/macbless: Fix potential overflow.
authorVladimir Serbinenko <phcoder@gmail.com>
Sat, 24 Jan 2015 20:12:02 +0000 (21:12 +0100)
committerVladimir Serbinenko <phcoder@gmail.com>
Sat, 24 Jan 2015 20:12:02 +0000 (21:12 +0100)
Is a minor concern as no such FS would be created under normal circumstances
and failure was benign.

Found by: Coverity scan.

grub-core/commands/macbless.c

index cf90eea204b26946facd4a64175df3fdee89c28a..f9e01b6f9c8d014eccbf5f576b8f15175b03f144 100644 (file)
@@ -106,7 +106,7 @@ grub_mac_bless_inode (grub_device_t dev, grub_uint32_t inode, int is_dir,
       ablk_size = grub_be_to_cpu32 (volheader.hfs.blksz);
       ablk_start = grub_be_to_cpu16 (volheader.hfs.first_block);
       embedded_offset = (ablk_start
-                        + extent_start
+                        + ((grub_uint64_t) extent_start)
                         * (ablk_size >> GRUB_DISK_SECTOR_BITS));
 
       err =