]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: imx219: Correct the minimum vblanking value
authorDavid Plowman <david.plowman@raspberrypi.com>
Tue, 4 Feb 2025 07:04:36 +0000 (12:34 +0530)
committerHans Verkuil <hverkuil@xs4all.nl>
Sat, 15 Feb 2025 14:22:59 +0000 (15:22 +0100)
The datasheet for this sensor documents the minimum vblanking as being
32 lines. It does fix some problems with occasional black lines at the
bottom of images (tested on Raspberry Pi).

Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/imx219.c

index 64227eb423d4311ebd93a0a0bd8bd17fa12e9623..dd5a8577d7479e22660b4d8fc9903a7c05bb6fad 100644 (file)
@@ -73,7 +73,7 @@
 #define IMX219_REG_VTS                 CCI_REG16(0x0160)
 #define IMX219_VTS_MAX                 0xffff
 
-#define IMX219_VBLANK_MIN              4
+#define IMX219_VBLANK_MIN              32
 
 /* HBLANK control - read only */
 #define IMX219_PPL_DEFAULT             3448