]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: libertas: main: don't call kfree_skb() under spin_lock_irqsave()
authorYang Yingliang <yangyingliang@huawei.com>
Wed, 7 Dec 2022 15:00:07 +0000 (23:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:26:35 +0000 (16:26 +0100)
[ Upstream commit f393df151540bf858effbd29ff572ab94e76a4c4 ]

It is not allowed to call kfree_skb() from hardware interrupt
context or with interrupts being disabled. So replace kfree_skb()
with dev_kfree_skb_irq() under spin_lock_irqsave(). Compile
tested only.

Fixes: d2e7b3425c47 ("libertas: disable functionality when interface is down")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221207150008.111743-4-yangyingliang@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/marvell/libertas/main.c

index feb204cd74a9a819a12b950cbfa5e1e7114c7322..21816f0e9e930f4fa62e81f736f07c944f9c0c2a 100644 (file)
@@ -216,7 +216,7 @@ int lbs_stop_iface(struct lbs_private *priv)
 
        spin_lock_irqsave(&priv->driver_lock, flags);
        priv->iface_running = false;
-       kfree_skb(priv->currenttxskb);
+       dev_kfree_skb_irq(priv->currenttxskb);
        priv->currenttxskb = NULL;
        priv->tx_pending_len = 0;
        spin_unlock_irqrestore(&priv->driver_lock, flags);